[issue15916] change doctest DocTestSuite not to raise ValueError if no docstrings

R. David Murray added the comment: Thanks, Glenn. -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue15916] change doctest DocTestSuite not to raise ValueError if no docstrings

Roundup Robot added the comment: New changeset 57fb5441a4aa by R David Murray in branch 'default': #15916: if there are no docstrings, make empty suite, not an error. http://hg.python.org/cpython/rev/57fb5441a4aa -- nosy: +python-dev ___ Python tracke

[issue15916] change doctest DocTestSuite not to raise ValueError if no docstrings

Glenn Jones added the comment: Added docs to patch -- Added file: http://bugs.python.org/file34848/issue15916-with-docs.patch ___ Python tracker ___ _

[issue15916] change doctest DocTestSuite not to raise ValueError if no docstrings

R. David Murray added the comment: This looks good, however we also need a documentation change indicating the new behavior, including a '.. versionchanged:: 3.5' tag, and an entry in whatsnew/3.5 in the 'other changes' section. -- ___ Python tracke

[issue15916] change doctest DocTestSuite not to raise ValueError if no docstrings

Glenn Jones added the comment: I've attached a patch that uses the original default DocTestFinder and does not raise an exception when there are no tests. -- nosy: +Glenn.Jones Added file: http://bugs.python.org/file34829/issue15916-no-exception.patch __

[issue15916] change doctest DocTestSuite not to raise ValueError if no docstrings

Changes by R. David Murray : -- Removed message: http://bugs.python.org/msg174145 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue15916] change doctest DocTestSuite not to raise ValueError if no docstrings

Changes by R. David Murray : -- Removed message: http://bugs.python.org/msg174146 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue15916] change doctest DocTestSuite not to raise ValueError if no docstrings

Petri Lehtinen added the comment: +for key in vars(subnamespace): +setattr(namespace, key, getattr(subnamespace, key)) There might be even more clever ways to achieve this, but what about at least saying "for key, value in vars(subnamespace).items()", and then using the valu

[issue15916] change doctest DocTestSuite not to raise ValueError if no docstrings

Petri Lehtinen added the comment: And that comment was meant for totally separate issue, sorry. -- ___ Python tracker ___ ___ Python-b

[issue15916] change doctest DocTestSuite not to raise ValueError if no docstrings

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue15916] change doctest DocTestSuite not to raise ValueError if no docstrings

Chris Jerdonek added the comment: Hmm. This patch still raises the "has no docstrings" ValueError if "not tests" is True. And because the patch changes the default DocTestFinder, it's possible that the patch changes behavior in non-error use cases. Why not just return an empty TestSuite if n

[issue15916] change doctest DocTestSuite not to raise ValueError if no docstrings

Tuukka Hastrup added the comment: I'm attaching a patch that changes DocTestSuite's default behaviour as suggested. -- keywords: +patch nosy: +tuukka Added file: http://bugs.python.org/file27673/issue15916.patch ___ Python tracker

[issue15916] change doctest DocTestSuite not to raise ValueError if no docstrings

New submission from Chris Jerdonek: Currently, calling doctest.DocTestSuite() raises a ValueError if the module passed to it has no docstrings. This was the subject of issue 14649. This issue is to discuss and possibly change DocTestSuite's behavior not to raise an exception in that situation