[issue15802] Nonsensical test for mailbox

Petri Lehtinen added the comment: Fixed, thanks. -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue15802] Nonsensical test for mailbox

Roundup Robot added the comment: New changeset aef4a2ba3210 by Petri Lehtinen in branch '3.2': #15802: Fix test logic in TestMaildir.test_create_tmp http://hg.python.org/cpython/rev/aef4a2ba3210 New changeset 2370e331241b by Petri Lehtinen in branch '2.7': #15802: Fix test logic in TestMaildir.t

[issue15802] Nonsensical test for mailbox

Petri Lehtinen added the comment: Techincally, converting to int is not necessary, because the number of digits in the unix timestamp doesn't change until year 2286 :) The patch looks good to me. I don't think comparing pairs would be any more readable than what the proposed patch does. -

[issue15802] Nonsensical test for mailbox

Chris Jerdonek added the comment: > In other words, (int(groups[0]), int(groups[1])) >= (int(previous_groups[0]), > int(previous_groups[1])). Why not use a single self.assertGreaterEqual() on the pairs (with an appropriate change in the message)? It currently hand-codes the lexicographic comp

[issue15802] Nonsensical test for mailbox

Serhiy Storchaka added the comment: Yes, the previous check nonsensical in two cases -- comparing strings and comparing with wrong value. groups[0] -- current seconds (str), groups[1] -- current milliseconds (str), previous_groups[0] -- previous seconds (str), previous_groups[1] -- previous mil