[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Changes by Stefan Mihaila : Added file: http://bugs.python.org/file30216/d0c3a8d4947a.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Stefan Mihaila added the comment: Hello. I apologize once again for not finalizing my work, but once I have started my final year of faculty and a job, I have been busy pretty much all the time. I would really like to finish this as I've really enjoyed working on it, and everything on PEP 3154

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Alexandre Vassalotti added the comment: I have started a new implementation of PEP 3154 since Stefan hasn't been active on his. Moving the discussion to Issue #17810. -- dependencies: -Unbinding of methods resolution: -> out of date stage: patch review -> committed/rejected status: op

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Antoine Pitrou added the comment: > Are there also some known techniques on tracking down memory leaks? Nothing more than the usual debugging techniques. It is more of a matter of taste whether you like to add print() (or printf ;-)) calls, or set breakpoints in an actual debugger. > i.e. pic

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Stefan Mihaila added the comment: Are there also some known techniques on tracking down memory leaks? I've played around with sys.gettotalrefcount to narrow down the place where the leaks occur, but they seem to only occur in v4, i.e. pickle.dumps(3.0+1j, 4) leaks but pickle.dumps(3.0+1j, 3) doe

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Antoine Pitrou added the comment: Le mercredi 22 août 2012 à 15:49 +, Stefan Mihaila a écrit : > I'm not sure this is the best way to benchmark, so let me know what is > usually used. http://hg.python.org/benchmarks/ has pickling benchmarks, you may have to modify them to test different pick

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Stefan Mihaila added the comment: >- I don't really like the idea of changing the semantics of the PUT and GET >opcodes. I would prefer new opcodes if possible. Well, the semantics of PUT and GET haven't really changed. It's just that the PUT opcode is not generated anymore and memoization is

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Alexandre Vassalotti added the comment: Some quick thoughts about the new implicit memoization scheme in Stefan's implementation. - The new scheme will need to be documented in PEP 3154 before we can accept the change. - I don't really like the idea of changing the semantics of the PUT and GE

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Stefan Mihaila added the comment: There are still some upcoming changes. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Antoine Pitrou added the comment: Is this patch stable? Or are there further changes coming? -- ___ Python tracker ___ ___ Python-bugs

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Stefan Mihaila added the comment: Maybe you can set this issue as the superseder of issue9269, because the patches there have already been applied here. -- ___ Python tracker __

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Alexandre Vassalotti added the comment: Oops, wrong patch. Uploading the right one. -- Added file: http://bugs.python.org/file26882/pickle4-2.diff ___ Python tracker ___

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Changes by Alexandre Vassalotti : Removed file: http://bugs.python.org/file26881/pickle4-2.diff ___ Python tracker ___ ___ Python-bugs-list ma

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Changes by Alexandre Vassalotti : -- dependencies: +Unbinding of methods ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Changes by Alexandre Vassalotti : Added file: http://bugs.python.org/file26881/pickle4-2.diff ___ Python tracker ___ ___ Python-bugs-list mail

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Stefan Mihaila added the comment: Maybe we could postpone the review process for a few days until I fix some known issues -- ___ Python tracker ___ __

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Alexandre Vassalotti added the comment: There are reference leaks in the _pickle.c part that will need to be fixed too. 22:36:29 [~/pickle4]$ ./python -m test.regrtest -R :: test_pickle [1/1] test_pickle beginning 9 repetitions 123456789 . test_pickle leaked [14780, 14780, 14780, 14780

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Alexandre Vassalotti added the comment: I get warnings when compiling with the patch: /home/avassalotti/pickle4/Modules/_pickle.c: In function ‘save_global_binary’: /home/avassalotti/pickle4/Modules/_pickle.c:2952: warning: pointer targets in passing argument 2 of ‘_Pickler_Write’ differ in si

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Changes by Alexandre Vassalotti : Added file: http://bugs.python.org/file26795/pickle4.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Changes by Alexandre Vassalotti : Removed file: http://bugs.python.org/file26794/pickle4.diff ___ Python tracker ___ ___ Python-bugs-list mail

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

Changes by Alexandre Vassalotti : Added file: http://bugs.python.org/file26794/pickle4.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue15642] Integrate pickle protocol version 4 GSoC work by Stefan Mihaila

New submission from Alexandre Vassalotti: Stefan Mihaila has been working on the implementation of PEP 3154, plus some other enhancements. His work is pretty complete and ready to be reviewed. I will do my best to finish a thorough review of his changes by the end of next week. -- ass