[issue15604] PyObject_IsTrue failure checks

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue15604] PyObject_IsTrue failure checks

Serhiy Storchaka added the comment: Thank you Antoine. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue15604] PyObject_IsTrue failure checks

Roundup Robot added the comment: New changeset ba1c48f8b571 by Antoine Pitrou in branch '2.7': Issue #15604: Update uses of PyObject_IsTrue() to check for and handle errors correctly. http://hg.python.org/cpython/rev/ba1c48f8b571 New changeset 56dc7b09f390 by Antoine Pitrou in branch '3.2': Iss

[issue15604] PyObject_IsTrue failure checks

Serhiy Storchaka added the comment: Patches updated again. -- Added file: http://bugs.python.org/file26838/istrue_check-3.3_3.patch Added file: http://bugs.python.org/file26839/istrue_check-3.2_3.patch Added file: http://bugs.python.org/file26840/istrue_check-2.7_3.patch ___

[issue15604] PyObject_IsTrue failure checks

Serhiy Storchaka added the comment: Patches updated to reflect Antoine's comments. -- Added file: http://bugs.python.org/file26813/istrue_check-3.3_2.patch Added file: http://bugs.python.org/file26814/istrue_check-3.2_2.patch Added file: http://bugs.python.org/file26815/istrue_check-2.7_

[issue15604] PyObject_IsTrue failure checks

Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue15604] PyObject_IsTrue failure checks

Serhiy Storchaka added the comment: I shall try to do this, but it will take a lot of time. Besides, now in the code there are a lot of *correct* checked usage of PyObject_IsTrue without test cases. So I'm not sure that the tests are needed here, and that they are worth the effort. --

[issue15604] PyObject_IsTrue failure checks

Antoine Pitrou added the comment: Is it possible to add test cases for (at least some of) these issues? -- nosy: +pitrou ___ Python tracker ___ __

[issue15604] PyObject_IsTrue failure checks

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file26743/istrue_check-3.2.patch ___ Python tracker ___ ___ Python-bugs-list

[issue15604] PyObject_IsTrue failure checks

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file26744/istrue_check-2.7.patch ___ Python tracker ___ ___ Python-bugs-list

[issue15604] PyObject_IsTrue failure checks

New submission from Serhiy Storchaka: PyObject_IsTrue can fail, but not everywhere in a code a returned value checked. Here is a patches which add such checks. Note, patches for all three Python versions are rather different. -- components: Interpreter Core, Library (Lib) files: istrue