[issue15596] pickle: Faster serialization of Unicode strings

STINNER Victor added the comment: Hi Antoine, I prefer your patch. Great job! 2013/4/7 Antoine Pitrou : > > Antoine Pitrou added the comment: > > I've applied the review comments and committed the patch. Thank you! > > -- > resolution: -> fixed > stage: patch review -> committed/rejecte

[issue15596] pickle: Faster serialization of Unicode strings

Antoine Pitrou added the comment: I've applied the review comments and committed the patch. Thank you! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker __

[issue15596] pickle: Faster serialization of Unicode strings

Roundup Robot added the comment: New changeset 09a84091ae96 by Antoine Pitrou in branch 'default': Issue #15596: Faster pickling of unicode strings. http://hg.python.org/cpython/rev/09a84091ae96 -- nosy: +python-dev ___ Python tracker

[issue15596] pickle: Faster serialization of Unicode strings

Changes by Antoine Pitrou : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue15596] pickle: Faster serialization of Unicode strings

Antoine Pitrou added the comment: Since protocol 0 is essentially dead in Python 3, I would like to propose something simpler and safer: only optimize the binary protocols. If noone beats me to it, I'll adapt Victor's patch for that. -- ___ Python t

[issue15596] pickle: Faster serialization of Unicode strings

Antoine Pitrou added the comment: Ping? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue15596] pickle: Faster serialization of Unicode strings

Serhiy Storchaka added the comment: Well, I take care of this. I have the own patch for raw_unicode_escape() optimization, but microbenchmarks don't show any speed up. Maybe your approach will be better. -- ___ Python tracker

[issue15596] pickle: Faster serialization of Unicode strings

STINNER Victor added the comment: serhiy: I'm not really motivated to finish the work on this issue (especially "... it would probably be good idea to benchmarks non-ASCII strings as well."). Would you like to work on this? -- nosy: +serhiy.storchaka __

[issue15596] pickle: Faster serialization of Unicode strings

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue15596] pickle: Faster serialization of Unicode strings

STINNER Victor added the comment: Last one: Python 3.2 vs patched Python 3.3. ned$ python3 perf.py -b fastpickle,pickle_dict,pickle_list,slowpickle ../3.2/python ../fasterpickle/python Running fastpickle... INFO:root:Running ../fasterpickle/python performance/bm_pickle.py -n 50 --use_cpickle p

[issue15596] pickle: Faster serialization of Unicode strings

Alexandre Vassalotti added the comment: Amazing! Though, it would probably be good idea to benchmarks non-ASCII strings as well. -- ___ Python tracker ___ __

[issue15596] pickle: Faster serialization of Unicode strings

STINNER Victor added the comment: For your information, results of benchmark comparing Python 3.2 to 3.3: ned$ python3 perf.py -b fastpickle,pickle_dict,pickle_list,slowpickle ../3.2/python ../default/python Running fastpickle... INFO:root:Running ../default/python performance/bm_pickle.py -n

[issue15596] pickle: Faster serialization of Unicode strings

STINNER Victor added the comment: Here is a benchmark comparing Python 3.3 without and with my patch ned$ python3 perf.py -b fastpickle,pickle_dict,pickle_list,slowpickle ../default/python ../fasterpickle/python Running fastpickle... INFO:root:Running ../fasterpickle/python performance/bm_pickl

[issue15596] pickle: Faster serialization of Unicode strings

Antoine Pitrou added the comment: Looks interesting. Can you post benchmark numbers? (you can use the pickle tests from http://hg.python.org/benchmarks ) -- ___ Python tracker __

[issue15596] pickle: Faster serialization of Unicode strings

STINNER Victor added the comment: Oh, I forgot to explain that I initially wrote the patch to fix the following failure on our "bigmem" buildbot. http://buildbot.python.org/all/builders/AMD64%20Ubuntu%20LTS%20bigmem%203.x/builds/165/steps/test/logs/stdio ===

[issue15596] pickle: Faster serialization of Unicode strings

New submission from STINNER Victor: Serialization of Unicode strings in the pickle module is suboptimal, especially for long strings. Attached patch optimize the serialization thanks to new properties of Unicode strings (PEP 393): * text (protocol 0): avoid any temporary buffer if the string