[issue15586] Provide some examples for usage of ElementTree methods/attributes

Changes by Eli Bendersky : -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Roundup Robot added the comment: New changeset 7012f6a74f66 by Eli Bendersky in branch 'default': Issue #15586: fix prompts in some documentation examples http://hg.python.org/cpython/rev/7012f6a74f66 -- ___ Python tracker

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Roundup Robot added the comment: New changeset 094423a65a4e by Eli Bendersky in branch '2.7': Issue #15586: porting ET's new documentation bits to 2.7. Patch by Daniel Ellis http://hg.python.org/cpython/rev/094423a65a4e -- ___ Python tracker

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Daniel Ellis added the comment: Made changes in structure in 2.7 branch to match 3.3 based on Eli's comments. Updated input prompt in examples per Ezio's review (though the default branch will still need this update). -- Added file: http://bugs.python.org/file26853/2.7_branch_etree_do

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Eli Bendersky added the comment: Daniel, this looks good except that the section numbering is different from 3.3 where the object/function reference sections were nested under "Reference". Could you fix your patch to align the 2.7 doc to this structure? P.S. Éric's comment also has to be fixed

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Roundup Robot added the comment: New changeset 8d90fde35cc6 by Eli Bendersky in branch 'default': Issue #15586: typo fix. This commit is accompanied by an apology for all Liechtensteiners out there, and a thanks to Eric Araujo for noticing. http://hg.python.org/cpython/rev/8d90fde35cc6

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Éric Araujo added the comment: I noticed a long-standing typo in the latest commit: the country is named Liechtenstein :) -- nosy: +eric.araujo ___ Python tracker ___ __

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Daniel Ellis added the comment: Thank you for the review Eli. I've made your changes and attached the updated patch. I did run all of the code snippets that are being added on 2.7, and the only thing I found different was the changed print statement. I don't believe I overlooked anything, b

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Eli Bendersky added the comment: I committed your patch to default (3.3) with some minor fixes. Please go over them as you will need to apply them to the 2.7 patch. I've reviewed the 2.7 patch as well - it's an initial review. Did you execute all the code samples on 2.7? -- _

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Roundup Robot added the comment: New changeset fc66730dae4c by Eli Bendersky in branch 'default': Issue #15586: add some examples to ElementTree documentation. Patch by Daniel Ellis. http://hg.python.org/cpython/rev/fc66730dae4c -- nosy: +python-dev

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Daniel Ellis added the comment: Fixed typo I made in examples in default branch. -- Added file: http://bugs.python.org/file26786/default_branch_etree_doc_3.patch ___ Python tracker _

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Daniel Ellis added the comment: I've updated 2.7 with the examples and made changes where backward compatibility was an issue. -- Added file: http://bugs.python.org/file26785/2.7_branch_etree_doc.patch ___ Python tracker

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Daniel Ellis added the comment: At the moment, the documentation for 2.7 is behind the documentation for 3.3. I will be working on backporting this next, but it will be a little more difficult than simply copying the existing documentation, since some key things in etree changed in the transi

[issue15586] Provide some examples for usage of ElementTree methods/attributes

R. David Murray added the comment: My understanding is that we try to keep the documentation of all active branches (2.7, 3.2, and 3.3 currently) in sync except where there are new features/new deprecations in the development version. So if the 2.7 docs are update, I think the 3.2 docs should

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Daniel Ellis added the comment: Changes to documentation per Ezio and Eli's suggestions. -- Added file: http://bugs.python.org/file26741/default_branch_etree_doc_2.patch ___ Python tracker _

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Eli Bendersky added the comment: Sarbjit: first of all, look at the up-to-date documentation for 3.3 (it's available online at http://docs.python.org/dev/ Then, on a checkout of the 3.3 code (default branch) you can apply Daniel's patch (it's in the "Files" section in this Issue) and look at t

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Eli Bendersky added the comment: Sarbjit, if you look at the docs of 3.3, I think most of what you're asking for is there (especially once you count Daniel's commit). What else is missing in your opinion? -- ___ Python tracker

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Changes by Eli Bendersky : -- versions: +Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Eli Bendersky added the comment: I provided some comments on your patch in the code-review tool. Thanks for the contribution, Daniel. It's fine to first apply these changes to 3.3 and then backport to 2.7 (I don't think 3.2 is necessary because most users use the online docs anyway).

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Changes by Eli Bendersky : -- versions: +Python 2.7, Python 3.3, Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Daniel Ellis added the comment: I've made a couple more additions/changes to the documentation in the default branch, per Eli's recommendation, since there were already a lot of good examples added. I'd like to also backport this to 2.7 but wanted to make sure these changes were good before m

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Eli Bendersky added the comment: Please note that the documentation of ET has been significantly improved in 3.3, with added examples, etc. You can start by backporting whatever is relevant to earlier versions (2.7/3.2) - do not add new documentation contents to 2.7/3.2 before the changes from

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Ezio Melotti added the comment: Usually a patch against "default" (i.e. Python 3) is enough, if there are several differences with Python 2 you might want to provide one for 2.7 too. See also the devguide at http://docs.python.org/devguide/ for more information about the workflow. --

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Daniel Ellis added the comment: Thank you Ezio, I will use that as a reference. What is the general workflow for updating documentation across python versions? Should I check to see if the documentation for the module changes across python versions and create patches for each version? Or is it

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Ezio Melotti added the comment: Daniel, I would suggest you to start with a basic example that gives an idea about how to use the module and its main functionalities. If necessary you could add a section at the bottom with more examples. You can also show how a method works with a short snippe

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Daniel Ellis added the comment: I have been working with ElementTree for the last few months and would love to help out with this. -- nosy: +Daniel.Ellis ___ Python tracker ___

[issue15586] Provide some examples for usage of ElementTree methods/attributes

New submission from Sarbjit singh: Please provide some basic usage examples for ElementTree module documentation. While parsing an xml, most common scenarios will be reading elements from xml, modifying elements, removal of elements. Though there are few examples given for modification of xml

[issue15586] Provide some examples for usage of ElementTree methods/attributes

Changes by Ezio Melotti : -- keywords: +easy nosy: +ezio.melotti stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list ma