[issue15550] Trailing white spaces

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue15550] Trailing white spaces

Ned Deily added the comment: Since we've established that python files are already covered by 'make patchcheck' and the hg checkin hook and that there does not appear to be much enthusiasm for extending the hook to C files or to wholesale whitespace cleanup, the remaining issue is whether to e

[issue15550] Trailing white spaces

Chris Jerdonek added the comment: Out of curiosity, is there a mechanism to bypass the hook on a per-file basis, if necessary? FWIW, the WebKit open source project had a similar hook (for SVN) to prevent the inclusion of tabs in source files, and a custom SVN property was used to bypass the c

[issue15550] Trailing white spaces

Terry J. Reedy added the comment: How is it more of a nuisance for C files than for .py files? Editor 'trim trailing' tools certainly don't care. -- nosy: +terry.reedy ___ Python tracker ___

[issue15550] Trailing white spaces

Stefan Krah added the comment: I'm not against whitespace cleanup every now and then, but also -0 on a hook for C files. I think that (for C) the annoyance of having a patch rejected because of trailing whitespace outweighs the overall benefit. -- nosy: +skrah __

[issue15550] Trailing white spaces

Ned Deily added the comment: -1 for making wholesale whitespace changes. It potentially makes merging harder for little benefit. Imported files from other projects should definitely not be touched. IMO, the only thing potentially worth considering is extending the existing hook to C files. I'

[issue15550] Trailing white spaces

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file26692/other_trailing_whitespaces.diff ___ Python tracker ___ ___ Python-b

[issue15550] Trailing white spaces

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file26691/c_trailing_whitespaces.diff ___ Python tracker ___ ___ Python-bugs-

[issue15550] Trailing white spaces

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file26690/libmpdec_trailing_whitespaces.diff ___ Python tracker ___ ___ Pytho

[issue15550] Trailing white spaces

Serhiy Storchaka added the comment: I found a few files where trailing spaces are significant (patches, RTF, test data). Excluding them and three generated file (Unicode data, generating scripts should be smarter), I divided the remaining into several parts: 1) the libffi library; 2) the libmp

[issue15550] Trailing white spaces

Georg Brandl added the comment: Well, I'm -0 on extending the hook to C files. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue15550] Trailing white spaces

Serhiy Storchaka added the comment: > There already is a hook in place for the main python.org repository that > checks for and rejects changesets that include files with space issues: Now I understand why there is no problem with .py files. But there are a lot of other files (including .c and

[issue15550] Trailing white spaces

Antoine Pitrou added the comment: AFAIR the hook only applies to Python and reST files, not C files. I think Georg wrote it, perhaps he knows the reasons. -- nosy: +georg.brandl ___ Python tracker _

[issue15550] Trailing white spaces

Chris Jerdonek added the comment: > There already is a hook in place for the main python.org repository that > checks for and rejects changesets that include files with space issues: If there is already a hook, then why do some files have spurious white space (i.e. at the end of a line)? Is t

[issue15550] Trailing white spaces

Antoine Pitrou added the comment: Or you can use "make patchcheck" which will (hopefully) warn you of such issues. -- nosy: +pitrou ___ Python tracker ___ ___

[issue15550] Trailing white spaces

Ned Deily added the comment: There already is a hook in place for the main python.org repository that checks for and rejects changesets that include files with space issues: http://hg.python.org/hooks/file/bd04c6b37749/checkwhitespace.py You can add it to your local repo to check patches befor

[issue15550] Trailing white spaces

Serhiy Storchaka added the comment: Because CPython repository contains binary files too, they should be reverted: hg diff | sed -nre 's/^Binary file (.*) has changed/\1/p' | tr '\n' '\0' | xargs -0 hg revert -- ___ Python tracker

[issue15550] Trailing white spaces

New submission from Serhiy Storchaka: My editors are configured to remove trailing spaces (this is useful for removing artifacts of indentation). The flip side of this is that my patches sometimes contain unrelated trailing spaces fixes. Trailing spaces are not significant in any CPython sourc