[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Raymond Hettinger added the comment: > What is left to do with this issue? Nothing that I can see. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Serhiy Storchaka added the comment: What is left to do with this issue? -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-b

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Changes by Raymond Hettinger : -- priority: release blocker -> normal resolution: fixed -> status: closed -> open versions: -Python 3.2, Python 3.3, Python 3.4 ___ Python tracker _

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Anselm Kruis added the comment: >> why the different fix for 3.3 > > I reverted the 2.7.4 addition of __dict__ rather than introduce more > differences between point releases with possible unintended effects. __dict__ was a 2.7.3 addition (changeset 26d5f022eb1a). Now unpickling of named tuple

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Roundup Robot added the comment: New changeset 31eaf8a137ea by Georg Brandl in branch '3.2': Issue #15535: Fix pickling of named tuples. http://hg.python.org/cpython/rev/31eaf8a137ea -- ___ Python tracker _

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Raymond Hettinger added the comment: > why the different fix for 3.3 I reverted the 2.7.4 addition of __dict__ rather than introduce more differences between point releases with possible unintended effects. In 3.3, the __dict__ attribute was there from the outset and was advertised in the do

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Ben Hoyt added the comment: 2.7 fix works for me, thanks! Just curious -- why the different fix for 3.3 (addition of __getstate__ instead of removal of __dict__)? -- ___ Python tracker

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Changes by Raymond Hettinger : -- assignee: amaury.forgeotdarc -> rhettinger resolution: -> fixed status: open -> closed ___ Python tracker ___ _

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Changes by Raymond Hettinger : -- Removed message: http://bugs.python.org/msg188064 ___ Python tracker ___ ___ Python-bugs-list mailin

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Roundup Robot added the comment: New changeset 65cd71abebc8 by Raymond Hettinger in branch '3.3': Issue #15535: Fix pickling of named tuples. http://hg.python.org/cpython/rev/65cd71abebc8 -- ___ Python tracker ___

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Roundup Robot added the comment: New changeset 18303391b981 by Raymond Hettinger in branch '2.7': Issue #15535: Fix regression in pickling of named tuples. http://hg.python.org/cpython/rev/18303391b981 -- nosy: +python-dev ___ Python tracker

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Changes by Florent Xicluna : -- nosy: +flox ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Changes by Raymond Hettinger : -- Removed message: http://bugs.python.org/msg188063 ___ Python tracker ___ ___ Python-bugs-list mailin

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Raymond Hettinger added the comment: Amaury, please go ahead and apply your patch. -- assignee: rhettinger -> amaury.forgeotdarc ___ Python tracker ___ __

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Raymond Hettinger added the comment: [Antoine] > I would like to call this a critical regression. I concur. I will post the suggested fix with tests. -- ___ Python tracker ___

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Changes by Georg Brandl : -- versions: +Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Changes by Antoine Pitrou : -- nosy: +georg.brandl, larry stage: -> needs patch versions: +Python 3.3, Python 3.4 ___ Python tracker ___

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Antoine Pitrou added the comment: I would like to call this a critical regression. Under 2.7 and 3.2, all pickle protocols are affected. Under 3.3 and 3.4, pickle protocols 0 and 1 are affected. (unfortunately, 3.2 doesn't receive bugfixes anymore) -- nosy: +benjamin.peterson, pitrou pr

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Changes by Raymond Hettinger : -- priority: normal -> high ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Ben Hoyt added the comment: I just hit this issue in a big way -- would have been nice for this fix to go into Python 2.7.4. :-) It was quite hard to track down (as in, a day or two of debugging :-) because the symptoms didn't point directly to namedtuple. In our setup we pickle/unpickle some

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Amaury Forgeot d'Arc added the comment: Adding "def __getstate__(self): return None" to the namedtuple template fixes the issue. Here is a patch with test. -- nosy: +amaury.forgeotdarc Added file: http://bugs.python.org/file27131/namedtuple-pickle.diff

[issue15535] Fix pickling efficiency of named tuples in 2.7.3

Raymond Hettinger added the comment: FWIW, all pickle protocol levels are affected: Point = colletions.namedtuple('Point', ['x', 'y', 'z']) for proto in range(3): pickletools.dis(dumps(Point(10, 20, 30), proto)) I'll look at the proposed fix in more detail when I get a chance -- we want to