[issue15238] shutil.copystat should copy Linux extended attributes

Hynek Schlawack added the comment: I removed the check for good as we check for the existence of the xattr in the next line. However we check the destination now whether the xattrs have been copied. ;) Fedora is green again. -- ___ Python tracker

[issue15238] shutil.copystat should copy Linux extended attributes

Roundup Robot added the comment: New changeset 265e36e277f3 by Hynek Schlawack in branch 'default': #15238: Fix xattr related shutil.copystat tests http://hg.python.org/cpython/rev/265e36e277f3 -- ___ Python tracker

[issue15238] shutil.copystat should copy Linux extended attributes

Larry Hastings added the comment: Hynek, it's clear you understand this far better than I do. Could I get you to fix the Fedora buildbot problem, etc, etc? -- ___ Python tracker _

[issue15238] shutil.copystat should copy Linux extended attributes

Hynek Schlawack added the comment: You can’t just compare the xattr because some (like security.*) can be only copied as root. IIRC they come from SELinux. -- ___ Python tracker ___

[issue15238] shutil.copystat should copy Linux extended attributes

Stefan Krah added the comment: The new test fails on the Fedora bot: http://buildbot.python.org/all/builders/AMD64%20Fedora%20without%20threads%203.x/builds/2881/steps/test/logs/stdio == FAIL: test_copyxattr (test.test_shutil.

[issue15238] shutil.copystat should copy Linux extended attributes

Changes by Larry Hastings : -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue15238] shutil.copystat should copy Linux extended attributes

Roundup Robot added the comment: New changeset 5f62c317c202 by Larry Hastings in branch 'default': - Issue #15238: shutil.copystat now copies Linux "extended attributes". http://hg.python.org/cpython/rev/5f62c317c202 -- nosy: +python-dev ___ Python t

[issue15238] shutil.copystat should copy Linux extended attributes

Hynek Schlawack added the comment: > Hynek: You must forgive me, I'm a recovering Windows programmer. I thought > extended attributes were a Linux-only thing. Can you tell me what other > platforms they are available on? And/or suggest some alternate language? http://en.wikipedia.org/wiki/

[issue15238] shutil.copystat should copy Linux extended attributes

Ned Deily added the comment: See open Issue12978. -- nosy: +ned.deily ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue15238] shutil.copystat should copy Linux extended attributes

Larry Hastings added the comment: Georg: done. Hynek: You must forgive me, I'm a recovering Windows programmer. I thought extended attributes were a Linux-only thing. Can you tell me what other platforms they are available on? And/or suggest some alternate language? -- __

[issue15238] shutil.copystat should copy Linux extended attributes

Georg Brandl added the comment: Yeah, good to go. But please re-insert a blank line in the test suite changes after the end of the method. -- ___ Python tracker ___ __

[issue15238] shutil.copystat should copy Linux extended attributes

Hynek Schlawack added the comment: The patch looks good enough. Not sure if we should write Linux though. I sincerely hope we’ll support xattrs on other OSes soonish. Did you catch Georg somewhere whether this can still go in? Would be nice as xattrs are new to 3.3. Changing this in 3.4 would

[issue15238] shutil.copystat should copy Linux extended attributes

Larry Hastings added the comment: First patch. -- keywords: +patch Added file: http://bugs.python.org/file26238/larry.copystat.xattrs.1.diff ___ Python tracker ___ _

[issue15238] shutil.copystat should copy Linux extended attributes

Changes by Antoine Pitrou : -- nosy: +hynek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue15238] shutil.copystat should copy Linux extended attributes

New submission from Larry Hastings : 3.3 adds the *xattr() extended attribute functions on Linux. shutil implements a new internal function(_copyxattr) which copies these extended attributes. However, it's only used in shutil.copy2(). I assert that shutil.copystat() should also preserve thi