[issue15219] Leak in "_hashlib.new()" if argument is not a string

2012-06-28 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: Fixed in 2.7, and ported test to 3.3. Thanks for the report and the fix! -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker

[issue15219] Leak in "_hashlib.new()" if argument is not a string

2012-06-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset c974c99acdf5 by Amaury Forgeot d'Arc in branch 'default': Port tests from Issue #15219, and verify we don't have a reference leak. http://hg.python.org/cpython/rev/c974c99acdf5 -- ___ Python tracker

[issue15219] Leak in "_hashlib.new()" if argument is not a string

2012-06-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset 49dee01d72f9 by Amaury Forgeot d'Arc in branch '2.7': Issue #15219: Fix a reference leak when hashlib.new() is called with http://hg.python.org/cpython/rev/49dee01d72f9 -- nosy: +python-dev ___ Python tr

[issue15219] Leak in "_hashlib.new()" if argument is not a string

2012-06-28 Thread Antoine Pitrou
Antoine Pitrou added the comment: Looks good to me. -- assignee: -> amaury.forgeotdarc nosy: +pitrou stage: -> commit review ___ Python tracker ___ ___

[issue15219] Leak in "_hashlib.new()" if argument is not a string

2012-06-28 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: Here is a test, which fails when I run regrtest with leak detection: ./python -m test.regrtest -R:: test_hashlib -- keywords: +patch nosy: +amaury.forgeotdarc Added file: http://bugs.python.org/file26203/hashlib-leak.patch ___

[issue15219] Leak in "_hashlib.new()" if argument is not a string

2012-06-28 Thread Jesús Cea Avión
Jesús Cea Avión added the comment: Could you possibly provide a testcase?. -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list

[issue15219] Leak in "_hashlib.new()" if argument is not a string

2012-06-28 Thread Michael Fötsch
Michael Fötsch added the comment: The change is against the 2.7 branch. The 3.2 branch is not affected. -- ___ Python tracker ___ ___

[issue15219] Leak in "_hashlib.new()" if argument is not a string

2012-06-28 Thread Michael Fötsch
New submission from Michael Fötsch : If the "name" argument to "_hashlib.new()" is not a string, the reference count for the "string" argument is not decremented. In the file "Modules/_hashopenssl.c", function "EVP_new()", a call to "PyBuffer_Release()" is missing: if (!PyArg_Parse(name_obj