[issue15163] pydoc displays __loader__ as module data

Brett Cannon added the comment: Don't worry about it, Eric. while the idea of grouping by concept is laudable, when the list is that long it's best to just alphabetize to make diffs easier to read. -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> clos

[issue15163] pydoc displays __loader__ as module data

Roundup Robot added the comment: New changeset 6a27b9f37b05 by Brett Cannon in branch 'default': Issue #15163: Pydoc shouldn't show __loader__ as a part of a module's http://hg.python.org/cpython/rev/6a27b9f37b05 -- nosy: +python-dev ___ Python tracke

[issue15163] pydoc displays __loader__ as module data

Éric Araujo added the comment: Sorry for the annoyance. I changed the order (and did not choose to alphabetize) because I thought it was easier to read with names grouped by topic, as I said in an earlier message, but please do as you think best. -- __

[issue15163] pydoc displays __loader__ as module data

Brett Cannon added the comment: I will alphabetize as part of the patch (I had the same issue myself of verifying the change). -- assignee: georg.brandl -> brett.cannon ___ Python tracker _

[issue15163] pydoc displays __loader__ as module data

Georg Brandl added the comment: Great to review such patches, where I have to take out a notepad and write the names down to check a 1-item addition. But it seems it does what's on the label, so go ahead. -- ___ Python tracker

[issue15163] pydoc displays __loader__ as module data

Brett Cannon added the comment: Georg, is it okay if I commit this on Eric's behalf for 3.3? -- assignee: -> georg.brandl nosy: +georg.brandl priority: low -> release blocker ___ Python tracker ___

[issue15163] pydoc displays __loader__ as module data

Éric Araujo added the comment: Now I have hardware issues, so no. -- assignee: eric.araujo -> ___ Python tracker ___ ___ Python-bugs-

[issue15163] pydoc displays __loader__ as module data

Brett Cannon added the comment: Can you still not commit this patch, Eric? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue15163] pydoc displays __loader__ as module data

Éric Araujo added the comment: I have internet problems at home and am not set up to work on Python at work, so feel free to commit the patch. -- ___ Python tracker ___ ___

[issue15163] pydoc displays __loader__ as module data

Changes by Brett Cannon : -- assignee: -> eric.araujo stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-lis

[issue15163] pydoc displays __loader__ as module data

Antoine Pitrou added the comment: Looks good to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue15163] pydoc displays __loader__ as module data

Éric Araujo added the comment: Attached patch does the trick. (Also removes extra whitespace in three lines and groups the ignored names by topic for ease of reading.) No test fails before or after the patch; there are some pydoc tests that check full text or HTML output, but apparently none

[issue15163] pydoc displays __loader__ as module data

New submission from Antoine Pitrou : Everything's in the title. __loader__ probably needs to be blacklisted. -- components: Library (Lib) messages: 163788 nosy: brett.cannon, eric.snow, pitrou priority: low severity: normal stage: needs patch status: open title: pydoc displays __loader__