[issue15103] Solaris compiler chokes on importlib.h

Antoine Pitrou added the comment: > As a general rule, generated files should not be included in the > repository. We already include generated files such as configure. This is either for convenience or for bootstrap purposes. > Recent mercurial versions include a "--large" parameter for "hg a

[issue15103] Solaris compiler chokes on importlib.h

Jesús Cea Avión added the comment: As a general rule, generated files should not be included in the repository. Recent mercurial versions include a "--large" parameter for "hg add" that threat files as binary. In particular, precludes "hg diff", that I guess it is the point here. --

[issue15103] Solaris compiler chokes on importlib.h

Antoine Pitrou added the comment: This should be fixed now. -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___

[issue15103] Solaris compiler chokes on importlib.h

Roundup Robot added the comment: New changeset 7d86e207598f by Antoine Pitrou in branch 'default': Issue #15103: remove the NUL character (serving as a Mercurial binary marker) from Python/importlib.h. http://hg.python.org/cpython/rev/7d86e207598f -- nosy: +python-dev

[issue15103] Solaris compiler chokes on importlib.h

Serhiy Storchaka added the comment: It looks as great disadvantage compared with Subversion. There are several ways to solve this problem: 1. Python/freeze_importlib.py generates a raw binary file Python/importlib.dump (just marshal dump) and this file is placed in the repository. Then a smal

[issue15103] Solaris compiler chokes on importlib.h

Antoine Pitrou added the comment: > What is the purpose of the comment at the end of "Python/importlib.h"? The purpose is to include a NUL character in the source file so that Mercurial treats this (generated) file as a binary file, and so that the diffs are omitted in commit notification e-m

[issue15103] Solaris compiler chokes on importlib.h

Justin Venus added the comment: What is the purpose of the comment at the end of "Python/importlib.h"? If I remove the comment that states "binary marker for mercurial" (something to that effect anyhow) the code compiles and only the tests fail. -- nosy: +Justin.Venus __

[issue15103] Solaris compiler chokes on importlib.h

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue15103] Solaris compiler chokes on importlib.h

New submission from Antoine Pitrou : The Solaris compiler chokes on the embedded NUL character. Perhaps we can find another way to remove the importlib.h diffs from the notification e-mails (simply hardcode the filename?). http://www.python.org/dev/buildbot/all/builders/x86%20Solaris%2011%203.