[issue15102] Fix 64-bit building for buildbot scripts (3.3)

Stefan Krah added the comment: Antoine Pitrou wrote: > Hmm, the buildbot fails compiling again after > af1d98b7ca801049803d83a85bb8558f6e59f2a1: > > http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/139 I think it's unrelated (probably ssl maintenance going on): cd

[issue15102] Fix 64-bit building for buildbot scripts (3.3)

Antoine Pitrou added the comment: Hmm, the buildbot fails compiling again after af1d98b7ca801049803d83a85bb8558f6e59f2a1: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/139 -- ___ Python tracker

[issue15102] Fix 64-bit building for buildbot scripts (3.3)

Stefan Krah added the comment: As far as I can see, the 3.3 buildbot scripts are fixed: After af1d98b7ca80 I can run Tools/buildbot/build.bat and Tools/buildbot/build-amd64.bat successfully in any order. I've run the tests, too, and I'm not getting the SHA1 failures. As requested, I've opened

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Martin v. Löwis added the comment: > Note that there also appears to be a compile error on the 3.2 and 2.7 > branches: Can we please, pretty pretty please, deal with one issue at a time? If you want to keep this issue open until everything works, you will probably see a dozen more commits, an

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Antoine Pitrou added the comment: Note that there also appears to be a compile error on the 3.2 and 2.7 branches: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.2 http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%202.7 Build started: Project: ssl, Configuration

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Roundup Robot added the comment: New changeset f12a2f2c93e5 by Stefan Krah in branch 'default': Issue #15102: Fix paths of python executables. http://hg.python.org/cpython/rev/f12a2f2c93e5 -- ___ Python tracker __

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Martin v. Löwis added the comment: Stefan: I think that's acceptable. Perhaps someone will come up with a better solution; if this works, it's good enough for me. -- ___ Python tracker ___

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Stefan Krah added the comment: outdir.diff contains a solution that doesn't rely on HOST_PYTHON. Works for both x64 and Win32. Note that I've edited the files using Vim. -- I'm not sure if one can even select Condition="'$(Platform)'=='Win32'" using Visual Studio. -- Added file: http:/

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Antoine Pitrou added the comment: Ouch. The test failures on the buildbot now seem to point to problems with OpenSSL's SHA1 implementation. Jeremy, perhaps you can try to run the OpenSSL self-tests? -- ___ Python tracker

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Stefan Krah added the comment: Jeremy, your python-dev suggestion to move x64.props before pyproject.props does not work for me. For instance, in python3dll.vcxproj: C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.MakeFile.Targets(38,5): error MSB3073: The comma nd "cd C:\Users\

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Stefan Krah added the comment: Jeremy Kloth wrote: > nasm.exe was installed for myself (hence testing worked). I've now > made it available to the buildbot account as well. > > Note that I have Perl installed but *not* on my PATH (on purpose). > The patch supplied in issue15052 will fix the i

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Jeremy Kloth added the comment: > Hmm, obviously Perl *is* found. That leaves nasm. nasm.exe was installed for myself (hence testing worked). I've now made it available to the buildbot account as well. Note that I have Perl installed but *not* on my PATH (on purpose). The patch supplied in is

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Stefan Krah added the comment: > Well, the path to python_d.exe looks right now, but Perl and nasm > aren't found: > > > "C:\Users\Buildbot\buildbot.python.org\3.x.kloth-win64\build\PCbuild\amd64\python_d.exe" > build_ssl.py Release x64 -a > > Found a working perl at 'C:\perl\bin\perl.ex

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Stefan Krah added the comment: Martin v. L??wis wrote: > Even if it does work out it should be reverted. As HOST_PYTHON is not > set, PythonExe should be computed correctly. So we really need to find > out why it isn't. Yes, of course. It's meant as a temporary measure to work out things like

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Martin v. Löwis added the comment: On 24.06.2012 13:22, Stefan Krah wrote: > > Stefan Krah added the comment: > > Well, the path to python_d.exe looks right now, but Perl and nasm > aren't found: perl shouldn't be necessary. Not sure why nasm is. --

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Martin v. Löwis added the comment: > I'm trying out my suggestion on the 64-bit bot. Will revert if it > doesn't work out. Even if it does work out it should be reverted. As HOST_PYTHON is not set, PythonExe should be computed correctly. So we really need to find out why it isn't. --

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Stefan Krah added the comment: Well, the path to python_d.exe looks right now, but Perl and nasm aren't found: "C:\Users\Buildbot\buildbot.python.org\3.x.kloth-win64\build\PCbuild\amd64\python_d.exe" build_ssl.py Release x64 -a Found a working perl at 'C:\perl\bin\perl.exe' 'nasm' is n

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Stefan Krah added the comment: I'm trying out my suggestion on the 64-bit bot. Will revert if it doesn't work out. -- ___ Python tracker ___

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Roundup Robot added the comment: New changeset fc84ac3e8dfc by Stefan Krah in branch 'default': Issue #15102: Try setting HOST_PYTHON in build-amd64.bat as a temporary http://hg.python.org/cpython/rev/fc84ac3e8dfc -- ___ Python tracker

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Stefan Krah added the comment: All Windows buildbots are failing now: C:\Program Files\MSBuild\Microsoft.Cpp\v4.0\Microsoft.MakeFile.Targets(38,5): error MSB3073: The command "cd "d:\cygwin\home\db3l\buildarea\3.x.bolen-windows\build\PCbuild\" [d:\cygwin\home\db3l\buildarea\3.x.bolen-windo

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Roundup Robot added the comment: New changeset 9c71d7f057b3 by Martin v. Löwis in branch 'default': Issue #15102: find python.exe in OutDir, not SolutionDir. http://hg.python.org/cpython/rev/9c71d7f057b3 -- ___ Python tracker

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Antoine Pitrou added the comment: There's still a problem when building ssl: Project "C:\Users\Buildbot\buildbot.python.org\3.x.kloth-win64\build\PCbuild\pcbuild.sln" (1) is building "C:\Users\Buildbot\buildbot.python.org\3.x.kloth-win64\build\PCbuild\_ssl.vcxproj" (18) on node 1 (default t

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Stefan Krah added the comment: Antoine Pitrou wrote: > Stefan, don't fear interfering. Merging is easy. Good to know, I loathe merging. :) -- ___ Python tracker ___ __

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Roundup Robot added the comment: New changeset c56783fe2e3b by Stefan Krah in branch 'default': Issue #15102: Fix paths in external-amd64.bat. http://hg.python.org/cpython/rev/c56783fe2e3b -- ___ Python tracker __

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Antoine Pitrou added the comment: Stefan, don't fear interfering. Merging is easy. -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Stefan Krah added the comment: I've fixed some paths in external-amd64.bat. Uploading a diff instead of committing right away so as not to interfere with the steadily incoming commits. -- Added file: http://bugs.python.org/file26114/external-amd64.diff _

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Roundup Robot added the comment: New changeset a9d4cf7d15b9 by Martin v. Löwis in branch 'default': Issue #15102: Use HOST_PYTHON only if it is set. http://hg.python.org/cpython/rev/a9d4cf7d15b9 -- ___ Python tracker

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Roundup Robot added the comment: New changeset 979567d33376 by Stefan Krah in branch 'default': Issue #15102: Allow platform-specific settings for the current project http://hg.python.org/cpython/rev/979567d33376 -- nosy: +python-dev ___ Python track

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Martin v. Löwis added the comment: Stefan: your patch looks good, please apply. -- ___ Python tracker ___ ___ Python-bugs-list mailin

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

Martin v. Löwis added the comment: > This change eliminates the need for HOST_PYTHON. Why is it required > in the first place? It is not documented as being required to build > Python. It helps to build 64-bit binaries on a 32-bit Windows installation. Normally, Python uses the python.exe it

[issue15102] Fix 64-bit building for buildbot scripts

Stefan Krah added the comment: I seem to be getting a functioning amd64 debug build by applying the small useenv.diff and then running: Tools\buildbot\build-amd64.bat -- Added file: http://bugs.python.org/file26108/useenv.diff ___ Python tracker

[issue15102] Fix 64-bit building for buildbot scripts

Georg Brandl added the comment: Of course these failures have to be fixed. But what Martin is saying is that for him (and probably other devs working on Windows) the build works, so the change must be done in the scripts only running on the buildbots. As for priority, we're two days away fro

[issue15102] Fix 64-bit building for buildbot scripts

Jeremy Kloth added the comment: > I can believe that there are issues with the batch files. That's why I propose > to look at one issue at a time (but it's not my priority at the moment). That would mean that you do not care that the buildbots are failing. That is exactly the reason that this b

[issue15102] Fix 64-bit building for buildbot scripts

Martin v. Löwis added the comment: >> > The debug build doesn't even *build*! That's the issue. >> >> It builds fine for me - I just tried. > > What command line do you use? Not the command line - I built from the IDE. My claim is if that works, no changes to the solution and project files sho

[issue15102] Fix 64-bit building for buildbot scripts

Stefan Krah added the comment: Martin v. L??wis wrote: > > The debug build doesn't even *build*! That's the issue. > > It builds fine for me - I just tried. What command line do you use? I tried: C:\Users\stefan\pydev\cpython>.\Tools\buildbot\build-amd64.bat Error: project file 'pcbuild.sl

[issue15102] Fix 64-bit building for buildbot scripts

Martin v. Löwis added the comment: > The most recent patch is correct. See my review then; I think it has issues. > The debug build doesn't even *build*! That's the issue. It builds fine for me - I just tried. -- ___ Python tracker

[issue15102] Fix 64-bit building for buildbot scripts

Jeremy Kloth added the comment: > As for the changes to project files and the solution file: none of these > changes should be necessary at all, unless it's actually the case that the > AMD64-Debug build doesn't work (i.e. neither in the buildbot, nor from the > solution file). As to the deb

[issue15102] Fix 64-bit building for buildbot scripts

Jeremy Kloth added the comment: > The patch, as it stands, is clearly incorrect (as has been reviewed and > acknowledged). The most recent patch is correct. > As for the changes to project files and the solution file: none of these > changes should be necessary at all, unless it's actually t

[issue15102] Fix 64-bit building for buildbot scripts

Martin v. Löwis added the comment: I think this really needs to be broken further down than "the AMD64 buildbot doesn't work". For each presumed failure, there should be one issue, and perhaps a proposed patch. The patch, as it stands, is clearly incorrect (as has been reviewed and acknowled

[issue15102] Fix 64-bit building for buildbot scripts

Georg Brandl added the comment: I'd like Martin to have a look at this. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue15102] Fix 64-bit building for buildbot scripts

Changes by Antoine Pitrou : -- nosy: +georg.brandl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue15102] Fix 64-bit building for buildbot scripts

Changes by Jeremy Kloth : Added file: http://bugs.python.org/file26095/5924b376d15f.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue15102] Fix 64-bit building for buildbot scripts

Antoine Pitrou added the comment: > Now that my buildbot is up and building (and failing at that) could > these changes be committed? Well, it would be nice if you could post an updated patch after the comments above. (I'm not saying I'm gonna commit, since I'm not a Windows expert, but it wi

[issue15102] Fix 64-bit building for buildbot scripts

Changes by Stefan Krah : -- nosy: +brian.curtin, loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue15102] Fix 64-bit building for buildbot scripts

Jeremy Kloth added the comment: Now that my buildbot is up and building (and failing at that) could these changes be committed? It would get the buildbot to at least start testing changes to Python proper. -- ___ Python tracker

[issue15102] Fix 64-bit building for buildbot scripts

Changes by Zachary Ware : -- nosy: +zach.ware ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue15102] Fix 64-bit building for buildbot scripts

Jeremy Kloth added the comment: On Mon, Jun 18, 2012 at 3:27 PM, Antoine Pitrou wrote: > If I understand, the proposed changes are the following: > https://bitbucket.org/jkloth/cpython-buildbot-amd64/changeset/2a20cee18add That seems to be correct, yes. > I'm not a Windows specialist, but the

[issue15102] Fix 64-bit building for buildbot scripts

Antoine Pitrou added the comment: If I understand, the proposed changes are the following: https://bitbucket.org/jkloth/cpython-buildbot-amd64/changeset/2a20cee18add ? I'm not a Windows specialist, but they do seem a bit weird: - the pcbuild.sln changes remove "Debug|x64.Build" and replaces "De

[issue15102] Fix 64-bit building for buildbot scripts

Jeremy Kloth added the comment: The unrelated changes do seem to be an issue with the diff generated by Rietveld -- nosy: +jeremy.kloth ___ Python tracker ___ __

[issue15102] Fix 64-bit building for buildbot scripts

Stefan Krah added the comment: There's some unrelated stuff in the patch that reverts commits in mpdecimal.c and multiprocessing. Maybe a Rietveld issue. -- nosy: +skrah ___ Python tracker

[issue15102] Fix 64-bit building for buildbot scripts

Changes by Antoine Pitrou : -- keywords: +patch Added file: http://bugs.python.org/file26047/2a20cee18add.diff ___ Python tracker ___

[issue15102] Fix 64-bit building for buildbot scripts

New submission from Jeremy Kloth : The buildbot scripts do not work for the 64-bit targets. Firstly, the "/p:UseEnv=True" parameter to msbuild causes the 32-bit only projects (make_buildinfo and make_versioninfo) to fail due to architecture mismatch. The scripts now unconditionally build thos