[issue15008] PEP 362 "Signature Objects" reference implementation

Yury Selivanov added the comment: Benjamin: http://bugs.python.org/issue15151 -- nosy: +yselivanov ___ Python tracker ___ ___ Python-

[issue15008] PEP 362 "Signature Objects" reference implementation

Benjamin Peterson added the comment: Are we going to get documentation? -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python

[issue15008] PEP 362 "Signature Objects" reference implementation

Changes by Larry Hastings : -- stage: patch review -> committed/rejected ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue15008] PEP 362 "Signature Objects" reference implementation

Changes by Yury Selivanov : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue15008] PEP 362 "Signature Objects" reference implementation

Roundup Robot added the comment: New changeset d892bf410478 by Larry Hastings in branch 'default': Issue #15008: Implement PEP 362 "Signature Objects". http://hg.python.org/cpython/rev/d892bf410478 -- nosy: +python-dev ___ Python tracker

[issue15008] PEP 362 "Signature Objects" reference implementation

Yury Selivanov added the comment: New patch - pep362.8.patch One big change (Guido's request) - No more AttributeErrors on missing Parameter.default of Signature.return_annotation. They now will be set to Parameter.empty & Signature.empty correspondingly. -- Added file: http://bugs.

[issue15008] PEP 362 "Signature Objects" reference implementation

Yury Selivanov added the comment: New patch - pep362.7.patch Summary: 1. Signature & Parameter objects are now immutable 2. Signature.replace() and Parameter.replace() 3. Signature has a new default constructor, which accepts parameters list and a return_annotation; and a new 'from_function'

[issue15008] PEP 362 "Signature Objects" reference implementation

Yury Selivanov added the comment: New patch - pep362.6.patch Ezio, I've eliminated almost all '\'. Test coverage is now almost 100%. -- Added file: http://bugs.python.org/file26055/pep362.6.patch ___ Python tracker

[issue15008] PEP 362 "Signature Objects" reference implementation

Ezio Melotti added the comment: I left a few comments on rietveld. The '\' is sometimes used where not necessary and the preferred way to write conditions on multiple lines is: (foo == bar and bar == baz and baz == asd) rather than foo == bar \ and bar == baz \ and baz == asd Have yo

[issue15008] PEP 362 "Signature Objects" reference implementation

Yury Selivanov added the comment: New patch (pep362.6.patch) Fixed a bug in BoundArguments.args when positional arguments were partially mapped by functools.partial -- Added file: http://bugs.python.org/file26053/pep362.6.patch ___ Python tracker

[issue15008] PEP 362 "Signature Objects" reference implementation

Yury Selivanov added the comment: New patch (pep362.5.patch) Fixed a bug in BoundArguments.args & BoundArguments.kwargs -- Added file: http://bugs.python.org/file26052/pep362.5.patch ___ Python tracker __

[issue15008] PEP 362 "Signature Objects" reference implementation

Yury Selivanov added the comment: Eric, I personally prefer simple 'signature()' more than 'get_signature()'. But I'll ask this question on python-dev on the next PEP update. -- ___ Python tracker _

[issue15008] PEP 362 "Signature Objects" reference implementation

Yury Selivanov added the comment: New version (pep363.4.patch) Summary: 1. Removed 'Signature.implemented' 2. No more patching built-ins - no issues with shared interpreters 3. Removed 'Signature.format()'. If needed we'll reintroduce it in 3.4 (although we still have 'Signature.__str__') 4.

[issue15008] PEP 362 "Signature Objects" reference implementation

Éric Araujo added the comment: One small thing: can we find a name for the function that starts with a verb? It’s the recommended naming style for functions, and would help making a difference between the class and the function. I also expect people to use “signature” and “sig” for their in

[issue15008] PEP 362 "Signature Objects" reference implementation

Yury Selivanov added the comment: Attaching the new version of the patch. Summary: 1. 'is_*' family was replaced with 'Parameter.kind' 2. 'signature()' function was updated to check for '__wrapped__' attribute in all callables 3. 'is_implemented' -> 'implemented' 4. Added support for POSITION

[issue15008] PEP 362 "Signature Objects" reference implementation

Yury Selivanov added the comment: Attaching a patch that implements the latest version of the PEP. Quick summary: 1. Ditched Signature.name & Signature.qualname 2. Added Signature.__eq__ and __ne__ 3. signature() supports classes, metaclasses, decorated stuff, partials, methods, classmethods,

[issue15008] PEP 362 "Signature Objects" reference implementation

Changes by Éric Araujo : -- keywords: +needs review stage: -> patch review title: PEP 362 reference implementation for 3.3 -> PEP 362 "Signature Objects" reference implementation ___ Python tracker __