[issue14769] Add test to automatically detect missing format units in skipitem()

Roundup Robot added the comment: New changeset 40d7869501a2 by Larry Hastings in branch 'default': Issue #14769: Incorporated mildly pedantic feedback from python-dev. http://hg.python.org/cpython/rev/40d7869501a2 -- ___ Python tracker

[issue14769] Add test to automatically detect missing format units in skipitem()

Changes by Larry Hastings : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue14769] Add test to automatically detect missing format units in skipitem()

Roundup Robot added the comment: New changeset ace45d23628a by Larry Hastings in branch 'default': Issue #14769: test_capi now has SkipitemTest, which cleverly checks http://hg.python.org/cpython/rev/ace45d23628a -- nosy: +python-dev ___ Python track

[issue14769] Add test to automatically detect missing format units in skipitem()

Benjamin Peterson added the comment: Okay -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue14769] Add test to automatically detect missing format units in skipitem()

Larry Hastings added the comment: Incorporates Benjamin's self-admitted pedantic changes ;-) Will it survive? Will it get checked in? Tune in... soon, I hope! -- Added file: http://bugs.python.org/file26064/larry.test_skipitem_parity.4.diff ___ Py

[issue14769] Add test to automatically detect missing format units in skipitem()

Larry Hastings added the comment: Changes incorporated from Benjamin's feedback. Thanks, Benjamin! Is this ready to go? -- Added file: http://bugs.python.org/file26060/larry.test_skipitem_parity.3.diff ___ Python tracker

[issue14769] Add test to automatically detect missing format units in skipitem()

Larry Hastings added the comment: Ping. Benjamin, should I find another reviewer? -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue14769] Add test to automatically detect missing format units in skipitem()

Larry Hastings added the comment: I guess the answer was "no". Attached is a new diff as you suggest. It isn't really any shorter--in fact it's about 20% longer. Though I freely admit it is more written-in-Python-y. The test currently passes. If you add support for a new format unit (like

[issue14769] Add test to automatically detect missing format units in skipitem()

Benjamin Peterson added the comment: Can you see if you can write that test in Python? Perhaps simply providing a wrapper to cal PyArg_Parse with the arguments you want. -- ___ Python tracker

[issue14769] Add test to automatically detect missing format units in skipitem()

New submission from Larry Hastings : I recently fixed an old bug: some time ago someone added support for a new "format unit", 'Z', to PyArg_Parse(), but neglected to add matching support for it to skipitem(). Benjamin asked for a regression test. Initially I said, okay, how the hell do I te