[issue1475] test_popen fails when the directory contains a space

Tim Golden added the comment: Fixed by issue2304 -- components: -Library (Lib), Tests, Windows nosy: +tim.golden resolution: -> duplicate stage: -> committed/rejected status: open -> closed type: -> behavior ___ Python tracker

[issue1475] test_popen fails when the directory contains a space

Russ Gibson added the comment: (Same comment I added to 1559298:) What is needed is separate quoting for the command and the argument. Right now, test_popen only surrounds the entire command line with quotes: "c:\Program Files\Python2.6\Python.exe -u c:\Documents and Settings\Russ Gibson\cgi-b

[issue1475] test_popen fails when the directory contains a space

Joseph Armbruster <[EMAIL PROTECTED]> added the comment: Should this issue be linked to 1559298? It appears to be the same issue but was opened up earlier and is referencing a different version. __ Tracker <[EMAIL PROTECTED]> __

[issue1475] test_popen fails when the directory contains a space

Peter Åstrand added the comment: >In Python 3.x os.popen is implemented based on subprocess. Oh, I see. >I believe it's still a problem with subprocess. I'm still not convinced of this. Isn't it better to do the quoting outside subprocess; to let the caller do it? You say that "section 2" i

[issue1475] test_popen fails when the directory contains a space

Changes by Gabriel Genellina: -- nosy: +gagenellina __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue1475] test_popen fails when the directory contains a space

Christian Heimes added the comment: In Python 3.x os.popen is implemented based on subprocess. I believe it's still a problem with subprocess. Python 3.x also drops support for Windows 95 to ME. Would the additional quoting be ok when the code checks for COMPSPEC == "cmd.exe" first? # Supply os.

[issue1475] test_popen fails when the directory contains a space

Peter Åstrand added the comment: I think there's some confusion in this bug. The report on http://pastebin.com/fa947767 indicates a problem in test_popen. This is a test for os.popen() and it does not have anything to do with the subprocess module. I believe it is test_popen.py that should be fix

[issue1475] test_popen fails when the directory contains a space

Christian Heimes added the comment: I like to have Peter Astrand look over the patch first. He has written most of the subprocess module. __ Tracker <[EMAIL PROTECTED]> __ _

[issue1475] test_popen fails when the directory contains a space

Joseph Armbruster added the comment: Applying quotations around args within the shell case appears to take care of it, any thoughts? Added file: http://bugs.python.org/file8788/subprocesspatch.patch __ Tracker <[EMAIL PROTECTED]>

[issue1475] test_popen fails when the directory contains a space

Joseph Armbruster added the comment: I believe the issue lies with the cmd command line parameters and insufficient quoting: Currently, if this string is passed into CreateProcess as args, the call will fail: C:\WINDOWS\System32\cmd.exe /c "C:\Documents and Settings\joe\Desktop\Development\Pyth

[issue1475] test_popen fails when the directory contains a space

Changes by Christian Heimes: -- priority: -> normal __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue1475] test_popen fails when the directory contains a space

New submission from Christian Heimes: Joseph found the bug during his testing of the py3k branch. The problem is in subprocess.py line 716. http://pastebin.com/fa947767 -- assignee: astrand components: Library (Lib), Tests, Windows keywords: py3k messages: 57696 nosy: astrand, joearmbru