[issue14732] PEP 3121 Refactoring applied to _csv module

Antoine Pitrou added the comment: Robin, I forgot: could you please sign and send the contrib form at http://www.python.org/psf/contrib/ ? It is not a copyright assignment, just a piece of paper that formally allows us to license your contribution for distribution with Python. -- ___

[issue14732] PEP 3121 Refactoring applied to _csv module

Antoine Pitrou added the comment: Thanks for the updated patch, Robin. I have now committed it to the default branch. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue14732] PEP 3121 Refactoring applied to _csv module

Roundup Robot added the comment: New changeset 2496602a56e5 by Antoine Pitrou in branch 'default': Issue #14732: The _csv module now uses PEP 3121 module initialization. http://hg.python.org/cpython/rev/2496602a56e5 -- ___ Python tracker

[issue14732] PEP 3121 Refactoring applied to _csv module

Roundup Robot added the comment: New changeset 90cf321615e5 by Antoine Pitrou in branch 'default': Remove Skip from the csv experts (see issue #14732). http://hg.python.org/devguide/rev/90cf321615e5 -- nosy: +python-dev ___ Python tracker

[issue14732] PEP 3121 Refactoring applied to _csv module

Changes by Robin Schreiber : Added file: http://bugs.python.org/file25559/csv_pep3121_fix1.patch ___ Python tracker ___ ___ Python-bugs-list m

[issue14732] PEP 3121 Refactoring applied to _csv module

Skip Montanaro added the comment: > Skip: I used the nosy field autocomplete which is based on the experts file > in the devguide; I can mark you "retired" in that file so that your name does > not show up in autocomplete (but humans will still know that you might be > contacted when all else

[issue14732] PEP 3121 Refactoring applied to _csv module

Éric Araujo added the comment: Skip: I used the nosy field autocomplete which is based on the experts file in the devguide; I can mark you "retired" in that file so that your name does not show up in autocomplete (but humans will still know that you might be contacted when all else fails, unl

[issue14732] PEP 3121 Refactoring applied to _csv module

Antoine Pitrou added the comment: PyModule_AddObject steals the value's reference, so you need to INCREF it before. Besides that, I don't see any obvious bug, but perhaps Martin wants to take a look. -- nosy: +pitrou priority: normal -> low stage: -> patch review ___

[issue14732] PEP 3121 Refactoring applied to _csv module

Skip Montanaro added the comment: > Changes by Éric Araujo : > > > -- > nosy: +skip.montanaro Thanks, but I'm out of the Python development business, except as it pertains to my day job... Skip -- nosy: +skip.montanaro ___ Python tracker <

[issue14732] PEP 3121 Refactoring applied to _csv module

Changes by Skip Montanaro : -- nosy: -skip.montanaro ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue14732] PEP 3121 Refactoring applied to _csv module

Changes by Éric Araujo : -- nosy: +skip.montanaro ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue14732] PEP 3121 Refactoring applied to _csv module

Changes by Martin v. Löwis : -- nosy: +loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue14732] PEP 3121 Refactoring applied to _csv module

Robin Schreiber added the comment: The following script should fail before you have applied the bespoken patch: It basically checks wether one of the global PyObjects inside the csv module is being deleted after freeing the csv module. -- Added file: http://bugs.python.org/file25474/r

[issue14732] PEP 3121 Refactoring applied to _csv module

New submission from Robin Schreiber : This patch presents my first try to apply the proposed Refactoring of PEP3121 to the csv module. I have identified three mutable global variables inside the module, two of which are references to PyObjects. I have wrapped all of them inside a dedicated str