[issue1473] Drop _EXPORTS macros in PCbuild9

Changes by Christian Heimes: -- resolution: -> fixed status: open -> closed __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list

[issue1473] Drop _EXPORTS macros in PCbuild9

Christian Heimes added the comment: WIN32 is required. Without WIN32 defined I'm getting errors in the locale module. _WINDOWS seems to be obsolete. __ Tracker <[EMAIL PROTECTED]> __ __

[issue1473] Drop _EXPORTS macros in PCbuild9

Martin v. Löwis added the comment: See the MSDN for details. IIUC: - _WIN32 is defined by the compiler, always, unless the platform is WIN16 (which is no longer supported). It is even defined on Win64 (where the compiler also defines _WIN64). So there should be no need to defined it explicitly. -

[issue1473] Drop _EXPORTS macros in PCbuild9

Christian Heimes added the comment: You are right. I've checked the header files of the dependencies or simply tried what happens when I remove some defines. The only macro existing macro is BZ2_EXPORT but that's defined unless BZ2_IMPORT is defined. What about the remaining defines? I've copied

[issue1473] Drop _EXPORTS macros in PCbuild9

New submission from Martin v. Löwis: I believe it is safe to drop all the _EXPORTS macros (MMAP_EXPORTS, WINSOUND_EXPORRTS etc) from all projects; atleast I cannot see any reason for having them. Some are clearly bogus, e.g. unicodedata and test_capi both define MMAP_EXPORTS, _socket defines WINS