[issue14572] 2.7.3: sqlite module does not build on centos 5 and Mac OS X 10.4

2013-04-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset 44fe1f5b07e3 by Serhiy Storchaka in branch '2.7': Issue #17857: Prevent build failures with pre-3.5.0 versions of sqlite3, http://hg.python.org/cpython/rev/44fe1f5b07e3 -- ___ Python tracker

[issue14572] 2.7.3: sqlite module does not build on centos 5 and Mac OS X 10.4

2012-05-20 Thread Marc Abramowitz
Marc Abramowitz added the comment: Ned, thanks for applying this patch! -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue14572] 2.7.3: sqlite module does not build on centos 5 and Mac OS X 10.4

2012-05-20 Thread Ned Deily
Ned Deily added the comment: > Isn't 3.2 or 3.3 affected by this? No, since the developer who made the original changes used sqlite3_int64 for 2.7 (789a3ea97083) but chose to hardwire the type to PyLong_AsLongLong for 3.x (e67715b87131). [corrected ids] -- __

[issue14572] 2.7.3: sqlite module does not build on centos 5 and Mac OS X 10.4

2012-05-20 Thread Ned Deily
Changes by Ned Deily : -- Removed message: http://bugs.python.org/msg161213 ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue14572] 2.7.3: sqlite module does not build on centos 5 and Mac OS X 10.4

2012-05-20 Thread Ned Deily
Ned Deily added the comment: > Isn't 3.2 or 3.3 affected by this? No, since the developer who made the original changes used sqlite3_int64 for 2.7 (37c824c3efe8) but chose to hardwire the type to PyLong_AsLongLong for 3.x (2d16048b10cd). -- ___ Py

[issue14572] 2.7.3: sqlite module does not build on centos 5 and Mac OS X 10.4

2012-05-20 Thread Petri Lehtinen
Petri Lehtinen added the comment: Isn't 3.2 or 3.3 affected by this? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue14572] 2.7.3: sqlite module does not build on centos 5 and Mac OS X 10.4

2012-05-19 Thread Ned Deily
Ned Deily added the comment: OK, the patch, as originally suggested by Joakim, is applied for release in 2.7.4. Thanks everyone. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue14572] 2.7.3: sqlite module does not build on centos 5 and Mac OS X 10.4

2012-05-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset e31597b3bd15 by Ned Deily in branch '2.7': Issue #14572: Prevent build failures with pre-3.5.0 versions of http://hg.python.org/cpython/rev/e31597b3bd15 -- nosy: +python-dev ___ Python tracker

[issue14572] 2.7.3: sqlite module does not build on centos 5 and Mac OS X 10.4

2012-05-19 Thread Petri Lehtinen
Petri Lehtinen added the comment: Changing the code to use sqlite_int64 (Ned's patch) sounds better to me. -- ___ Python tracker ___

[issue14572] 2.7.3: sqlite module does not build on centos 5 and Mac OS X 10.4

2012-05-19 Thread Marc Abramowitz
Marc Abramowitz added the comment: Probably either approach will have the exact same effect for the foreseeable future, so I don't feel strongly either way. It would be nice to have one of them so folks can have a sqlite3 module without having to search around and apply patches. Big win.

[issue14572] 2.7.3: sqlite module does not build on centos 5 and Mac OS X 10.4

2012-05-19 Thread Marc Abramowitz
Marc Abramowitz added the comment: My guess would be that the code was switched to use the new typedef because the SQLite docs say they're preferred. http://www.sqlite.org/c3ref/int64.html Maybe they are planning to deprecate the old typedef at some point? -- __

[issue14572] 2.7.3: sqlite module does not build on centos 5 and Mac OS X 10.4

2012-05-19 Thread Ned Deily
Ned Deily added the comment: Thanks for the patch to configure.ac. It appears to work on OS X 10.4 and it should on any other system with an older version of sqlite3 installed. However, I think a better approach is to just change the two problematic references in Modules/_sqlite/connection.c

[issue14572] 2.7.3: sqlite module does not build on centos 5 and Mac OS X 10.4

2012-05-19 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +dmalcolm ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue14572] 2.7.3: sqlite module does not build on centos 5 and Mac OS X 10.4

2012-05-19 Thread Marc Abramowitz
Marc Abramowitz added the comment: OK, here's a patch for configure.ac which seems to fix this problem -- if folks could review and test it that would be great. -- keywords: +patch Added file: http://bugs.python.org/file25634/sqlite3_int64.patch ___

[issue14572] 2.7.3: sqlite module does not build on centos 5 and Mac OS X 10.4

2012-05-18 Thread Marc Abramowitz
Marc Abramowitz added the comment: curl -sk https://raw.github.com/gist/2727063/ | patch -p1 -- ___ Python tracker ___ ___ Python-bug

[issue14572] 2.7.3: sqlite module does not build on centos 5 and Mac OS X 10.4

2012-05-18 Thread Marc Abramowitz
Marc Abramowitz added the comment: Just to make this a tad easier, I put Joakim's patch into a gist: [marca@logger01.prod1 Python-2.7.3]$ pwd /home/marca/src/Python-2.7.3 [marca@logger01.prod1 Python-2.7.3]$ curl -sk https://raw.github.com/gist/2727063/ | patch -p1 pat

[issue14572] 2.7.3: sqlite module does not build on centos 5 and Mac OS X 10.4

2012-05-04 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Mac OS X 10.4 is also affected and for the same reason. SQLite builds fine for Python 2.5 and 2.6, but not for 2.7. -- nosy: +lemburg title: 2.7.3: sqlite module does not build on centos 5 -> 2.7.3: sqlite module does not build on centos 5 and Mac