[issue14569] pystate.c #ifdef ordering problem

Jim Jewett added the comment: On Fri, Apr 13, 2012 at 6:19 AM, Antoine Pitrou added the comment: > I don't think you need anyone's permission to commit such a fix :) Well, *I* would, since I don't have commit privs, and don't currently have a C dev environment with which to test. But I figur

[issue14569] pystate.c #ifdef ordering problem

Roundup Robot added the comment: New changeset 508ae5d27c2c by Benjamin Peterson in branch '2.7': take linkage def outside of WITH_THREAD conditional (closes #14569) http://hg.python.org/cpython/rev/508ae5d27c2c -- ___ Python tracker

[issue14569] pystate.c #ifdef ordering problem

Roundup Robot added the comment: New changeset 5cc359804d61 by Benjamin Peterson in branch '3.2': take linkage def outside of WITH_THREAD conditional (closes #14569) http://hg.python.org/cpython/rev/5cc359804d61 -- nosy: +python-dev resolution: -> fixed stage: needs patch -> committed/

[issue14569] pystate.c #ifdef ordering problem

Antoine Pitrou added the comment: I don't think you need anyone's permission to commit such a fix :) -- nosy: +pitrou ___ Python tracker ___

[issue14569] pystate.c #ifdef ordering problem

Jim Jewett added the comment: http://hg.python.org/cpython/file/0f114b855824/Python/pystate.c#l25 #ifdef WITH_THREAD #include "pythread.h" static PyThread_type_lock head_mutex = NULL; /* Protects interp->tstate_head */ #define HEAD_INIT() (void)(head_mutex || (head_mutex = PyThread_allocate_l

[issue14569] pystate.c #ifdef ordering problem

New submission from Jim Jewett : The C linkage is guarded by WITH_THREAD. The 'extern "C" {' and '}' declarations should be in effect regardless of threading. Note that the bug can only be triggered by compiling without threads, but with a C++ compiler; this is obscure enough that I don't fee