[issue14366] Supporting lzma compression in zip files

Serhiy Storchaka added the comment: Thank you, Martin. Both of these patches basically your merit. Maybe take a look also at the small patches to issue14315 and issue10376? -- ___ Python tracker _

[issue14366] Supporting lzma compression in zip files

Martin v. Löwis added the comment: Thanks for the patch! -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ P

[issue14366] Supporting lzma compression in zip files

Roundup Robot added the comment: New changeset fccdcd83708a by Martin v. Löwis in branch 'default': Issue #14366: Support lzma compression in zip files. http://hg.python.org/cpython/rev/fccdcd83708a -- nosy: +python-dev ___ Python tracker

[issue14366] Supporting lzma compression in zip files

Serhiy Storchaka added the comment: I understand you, Martin. The time it took me to read the specification and understand where should be the checks in the module. The patch updated. The list of compression methods extended (in the future it can be used for detailed output in the printdir()), f

[issue14366] Supporting lzma compression in zip files

Martin v. Löwis added the comment: Serhiy, just to be sure we communicated well: I'm not asking that all the missing features for a 6.3 level zip library must be implemented. Instead, we need to detect whether an unsupported feature is used, and raise an exception reporting what the feature i

[issue14366] Supporting lzma compression in zip files

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file25430/lzma_in_zip.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue14366] Supporting lzma compression in zip files

Serhiy Storchaka added the comment: The patch updated to use functions encode_filter_properties and decode_filter_properties from the lzma module. Thank you, Nadeem Vawda. -- Added file: http://bugs.python.org/file25488/lzma_in_zip_2.patch ___ Pytho

[issue14366] Supporting lzma compression in zip files

Nadeem Vawda added the comment: I've committed my patch as changeset 9118ef2b651a, adding functions encode_filter_properties and decode_filter_properties to the lzma module. -- ___ Python tracker _

[issue14366] Supporting lzma compression in zip files

Nadeem Vawda added the comment: I've put together a patch for the lzma module adding functions for encoding and decoding filter properties (see issue 14736). It's a bit bulky, though, so I'd like to get a review before committing it. -- ___ Python tr

[issue14366] Supporting lzma compression in zip files

Antoine Pitrou added the comment: > Note that the supporting of bzip2 increases the time of testing > test_zipfile in 1.5x, and lzma -- 2x (total 3x). May be not all tests > are needed? I think it's ok. Some of our tests run quite longer than that; and better to be exhaustive than fast (even t

[issue14366] Supporting lzma compression in zip files

Martin v. Löwis added the comment: I'm not sure where the test run time actually comes from. It's certainly desirable to reduce the test run time, as long as all test purposes are preserved. It's not necessary to do redundant tests, e.g. if some test isn't about compression, there is no point

[issue14366] Supporting lzma compression in zip files

Serhiy Storchaka added the comment: Note that the supporting of bzip2 increases the time of testing test_zipfile in 1.5x, and lzma -- 2x (total 3x). May be not all tests are needed? -- ___ Python tracker _

[issue14366] Supporting lzma compression in zip files

Serhiy Storchaka added the comment: Here is the patch which adds support for lzma in zipfile. Later I'll move `lzma_props_encode` and `lzma_props_decode` to lzma module. -- Added file: http://bugs.python.org/file25430/lzma_in_zip.patch ___ Python tra

[issue14366] Supporting lzma compression in zip files

Changes by Martin v. Löwis : -- title: Supporting bzip2 and lzma compression in zip files -> Supporting lzma compression in zip files ___ Python tracker ___