[issue14366] Supporting bzip2 and lzma compression in zip files

Serhiy Storchaka added the comment: > Regarding changes to lzma; exactly what is being proposed? Yes, it's just additional functions for encoding and decoding of filter specs. But this is not necessary, the current implementation uses own functions (need the support of only LZMA1 format, whi

[issue14366] Supporting bzip2 and lzma compression in zip files

Serhiy Storchaka added the comment: > For EOS, please re-read the specification. Well, nothing prevents the setting of this bit. Lzma raw compressor already appends EOS. -- ___ Python tracker ___

[issue14366] Supporting bzip2 and lzma compression in zip files

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file25007/bzip2_and_lzma_in_zip_3.patch ___ Python tracker ___ ___ Python-bug

[issue14366] Supporting bzip2 and lzma compression in zip files

Nadeem Vawda added the comment: I plan on doing a review of the patch, but it might be a week or two before I have time to do it. Regarding changes to lzma; exactly what is being proposed? If it's just additional functions for encoding and decoding of filter specs, then I'm fine with that (and

[issue14366] Supporting bzip2 and lzma compression in zip files

Serhiy Storchaka added the comment: Issue #14371: Add support for bzip2 compression to the zipfile module. -- ___ Python tracker ___

[issue14366] Supporting bzip2 and lzma compression in zip files

Martin v. Löwis added the comment: For EOS, please re-read the specification. If you then still think it is not needed, read it again :-) The documentation in liblzma is irrelevant, only the PKWARE specification matters. Take particular notice of the phrase "implementers should include the EO

[issue14366] Supporting bzip2 and lzma compression in zip files

Serhiy Storchaka added the comment: Thank you, Martin, for review and advices. Lzma in zip format: 2-bytes version (LZMA SDK version, it has not relations with version of XZ Utils used by lzma module), 2-bytes properties size (I have not seen a value other than 5), N-bytes (N=5) property data

[issue14366] Supporting bzip2 and lzma compression in zip files

Martin v. Löwis added the comment: I also think that create_version and extract_version need to be adjusted. Since LZMA is version 6.3, we need to check for any features that might be in a zip file of extract version 6.3 or lower that we do not support (such as PPMd+ compression, strong encr

[issue14366] Supporting bzip2 and lzma compression in zip files

Martin v. Löwis added the comment: ISTM that the LZMA support differs from the specification, see http://www.pkware.com/documents/casestudies/APPNOTE.TXT In particular, there appears to be no support for the EOS marker, which should be emitted when compressing. Changing the LZMA module is fi

[issue14366] Supporting bzip2 and lzma compression in zip files

Changes by Éric Araujo : -- nosy: +eric.araujo title: Suporting bzip2 and lzma compression in zip files -> Supporting bzip2 and lzma compression in zip files ___ Python tracker