[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

Changes by Larry Hastings : -- keywords: -patch resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

Roundup Robot added the comment: New changeset 052779d34945 by Larry Hastings in branch 'default': Issue #14328: Add keyword-only parameters to PyArg_ParseTupleAndKeywords. http://hg.python.org/cpython/rev/052779d34945 -- nosy: +python-dev ___ Python

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

Benjamin Peterson added the comment: Fine with me now. 2012/3/19 Larry Hastings : > > Larry Hastings added the comment: > > Whoops!  Actually, I did.  But then I promptly forgot about them.  They're > now all incorporated; please see attached patch. > > -- > Added file: http://bugs.py

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

Larry Hastings added the comment: Whoops! Actually, I did. But then I promptly forgot about them. They're now all incorporated; please see attached patch. -- Added file: http://bugs.python.org/file24955/larry.parsekwonly.diff.7.txt ___ Python tra

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

Benjamin Peterson added the comment: Did you not see Georg's comments? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

Larry Hastings added the comment: Anyone else? Or can I get the go-ahead? -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

Larry Hastings added the comment: Incorporated the latest round of suggestions from Benjamin's most recent--and very thorough!--review. Thanks, Benjamin! -- Added file: http://bugs.python.org/file24912/larry.parsekwonly.diff.5.txt ___ Python tracke

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

Larry Hastings added the comment: > Shouldn't using vgetargs1 with '$' in the format string just be > an error? vgetargs1 doesn't know anything about keyword arguments. Thank you for catching that! Serves me right for search-and-destroy style development--I'm not that familiar with getargs.c.

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

Benjamin Peterson added the comment: Shouldn't using vgetargs1 with '$' in the format string just be an error? vgetargs1 doesn't know anything about keyword arguments. -- ___ Python tracker __

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

Larry Hastings added the comment: Attached is r3 of my patch incorporated Benjamin's suggestions. > I want #14325 to go in first. Why do you care? If I get signoff before 14325 does please explain to me why I should wait. They don't touch the same lines; should be a clean merge no matter w

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

Benjamin Peterson added the comment: I want #14325 to go in first. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

Changes by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

Larry Hastings added the comment: BTW, I have the os.utime patch nearly ready for review; it works, it just needs doc and test. But it's dependent on this patch--and it'd be smoother if #14127 were finished too. So I'll hold off on posting the new patch until the fates of these two are deci

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

Larry Hastings added the comment: How about we leave it for now, and if we need it later we can fix the implementation. Adding that feature won't break existing calls--we'll just permit $ to occur before/without | in the format string. -- ___ Pyth

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

Benjamin Peterson added the comment: 2012/3/15 Larry Hastings : > > Larry Hastings added the comment: > > It frankly never occurred to me that you'd want mandatory keyword-only > arguments.  Implementing them as optional-only was easy; I'm not sure but > making them possibly mandatory (or bot

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

Larry Hastings added the comment: It frankly never occurred to me that you'd want mandatory keyword-only arguments. Implementing them as optional-only was easy; I'm not sure but making them possibly mandatory (or both!) might complicate matters. Is there a use case for 'em? --

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

Benjamin Peterson added the comment: Why do you force them to be optional? -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Pyt

[issue14328] Add keyword-only parameter support to PyArg_ParseTupleAndKeywords

New submission from Larry Hastings : This has been split off from #14127 at Antoine's request. The attached patch adds support for keyword-only arguments to the PyArg_ParseTupleAndKeywords() family of functions. Includes doc and test. I used '$' to indicate "all parameters after this are keyw