[issue14295] PEP 417: adding mock module

2012-09-28 Thread Michael Foord
Michael Foord added the comment: unittest.mock addition is complete. -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___

[issue14295] PEP 417: adding mock module

2012-03-17 Thread Michael Foord
Michael Foord added the comment: Interesting. As I have to keep the external version of mock in sync with unittest.mock, and I have more important things to do first (like the docs) it would be a gratuitous change for no benefit. If you have any more substantive suggestions for code cleanup t

[issue14295] PEP 417: adding mock module

2012-03-15 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue14295] PEP 417: adding mock module

2012-03-14 Thread Éric Araujo
Éric Araujo added the comment: “If your public attribute name collides with a reserved keyword, append a single trailing underscore to your attribute name. This is preferable to an abbreviation or corrupted spelling. (However, notwithstanding this rule, 'cls' is the preferred spelling for a

[issue14295] PEP 417: adding mock module

2012-03-14 Thread Michael Foord
Michael Foord added the comment: Feel free to suggest changes on this issue. _callable can probably go now I agree. cls is only suggested by PEP 8 for classmethods I believe, and off the top of my head I don't think mock has any of those. -- ___

[issue14295] PEP 417: adding mock module

2012-03-14 Thread Éric Araujo
Éric Araujo added the comment: I’ve seen some things to clean up in the code, like the fact that callable is back in 3.2+, or (I hate to point this) the ugly-according-to-PEP-8 klass instead of cls; I may read the code more carefully later if it helps. -- nosy: +eric.araujo _

[issue14295] PEP 417: adding mock module

2012-03-13 Thread Michael Foord
New submission from Michael Foord : PEP 417: Including mock in the Standard Library http://www.python.org/dev/peps/pep-0417/ Tasks: * Add mock with tests * Cleanup mock code to remove Python 2 compatibility * Add documentation I'll close this issue when all the tasks are complete. --