[issue14235] test_cmd.py does not correctly call reload()

Berker Peksag added the comment: Fixed. Thanks for the report. -- assignee: eric.araujo -> berker.peksag nosy: +berker.peksag, r.david.murray resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3 __

[issue14235] test_cmd.py does not correctly call reload()

Roundup Robot added the comment: New changeset d943089af1c6 by Berker Peksag in branch '3.4': Issue #14235: Use importlib.reload() in test_cmd.test_coverage. http://hg.python.org/cpython/rev/d943089af1c6 New changeset 10a1e7780ee7 by Berker Peksag in branch 'default': Issue #14235: Merge from 3.

[issue14235] test_cmd.py does not correctly call reload()

Mark Lawrence added the comment: The patch has not been applied to the default or 3.4 branches. -- nosy: +BreamoreBoy ___ Python tracker ___ _

[issue14235] test_cmd.py does not correctly call reload()

Éric Araujo added the comment: Ah, right. Will apply your patch. -- assignee: -> eric.araujo versions: +Python 3.2 ___ Python tracker ___ _

[issue14235] test_cmd.py does not correctly call reload()

Josh Watson added the comment: That particular function only gets called by running `./python Lib/test/test_cmd.py -c`, and not through regrtest.py, so I suspect that's why it wasn't noticed before. I just happened to be exploring test files and ran into an unhandled exception when I tried ru

[issue14235] test_cmd.py does not correctly call reload()

Éric Araujo added the comment: Thanks for the report and patch. This begs the question: why does the current buggy code not cause a test failure? -- nosy: +eric.araujo ___ Python tracker

[issue14235] test_cmd.py does not correctly call reload()

Changes by Josh Watson : -- type: crash -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue14235] test_cmd.py does not correctly call reload()

Josh Watson added the comment: Accidentally submitted before finishing typing. Anyways, it calls "reload(cmd)" in the test_coverage function in test_cmd.py, which does not work anymore given that reload has been moved to imp. I've uploaded a patch that fixes this. -- keywords: +patch

[issue14235] test_cmd.py does not correctly call reload()

New submission from Josh Watson : The test_coverage function in test_cmd.py calls reload(cmd) -- components: Tests messages: 155200 nosy: Josh.Watson priority: normal severity: normal status: open title: test_cmd.py does not correctly call reload() type: crash versions: Python 3.3 _