[issue14203] PEP-3118: remove obsolete write-locks

Stefan Krah added the comment: I think it's sufficient to test bytesiobuf_getbuffer() on Linux and FreeBSD. The test just checks that the exception is raised. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python

[issue14203] PEP-3118: remove obsolete write-locks

Roundup Robot added the comment: New changeset 17a8c5f8ca48 by Stefan Krah in branch 'default': Issue #14203: Temporary fix for the compile failure on Windows. https://hg.python.org/cpython/rev/17a8c5f8ca48 -- ___ Python tracker

[issue14203] PEP-3118: remove obsolete write-locks

Stefan Krah added the comment: Argh, the extern _PyBytesIOBuffer_Type hack. I knew it would cause some trouble. Any ideas how to test bytesiobuf_getbuffer() with a NULL view in a more dignified way? -- ___ Python tracker

[issue14203] PEP-3118: remove obsolete write-locks

Serhiy Storchaka added the comment: Compiling failed on Windows: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/5650 -- ___ Python tracker ___ _

[issue14203] PEP-3118: remove obsolete write-locks

Roundup Robot added the comment: New changeset 0d5095a2422f by Stefan Krah in branch 'default': Issue #14203: Remove obsolete support for view==NULL in bytesiobuf_getbuffer() https://hg.python.org/cpython/rev/0d5095a2422f -- ___ Python tracker

[issue14203] PEP-3118: remove obsolete write-locks

Stefan Krah added the comment: Ok, thanks! issue14203-3.diff should be correct, then. -- Added file: http://bugs.python.org/file38004/issue14203-3.diff ___ Python tracker ___ __

[issue14203] PEP-3118: remove obsolete write-locks

Serhiy Storchaka added the comment: E.g. the buffer should be unshared before incrementing b->exports, but if an exception is raised instead, there is no need to unshare the buffer before raising. -- ___ Python tracker

[issue14203] PEP-3118: remove obsolete write-locks

Serhiy Storchaka added the comment: I think before. It doesn't harm, but it doesn't make much sense to unshare the buffer if its address is not used. -- ___ Python tracker ___ _

[issue14203] PEP-3118: remove obsolete write-locks

Stefan Krah added the comment: bytesiobuf_getbuffer() also still has this obsolete feature, so BufferError should be raised if view==NULL. I'm unsure if this plays well with the new SHARED_BUF(b) thing. Should the exception be raised before or after? -- nosy: +serhiy.storchaka title: b