[issue14172] ref-counting leak in buffer usage in Python/marshal.c

Antoine Pitrou added the comment: Fixed. Apparently 2.7 isn't affected. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue14172] ref-counting leak in buffer usage in Python/marshal.c

Roundup Robot added the comment: New changeset 185a6ae76479 by Antoine Pitrou in branch '3.2': Issue #14172: Fix reference leak when marshalling a buffer-like object (other than a bytes object). http://hg.python.org/cpython/rev/185a6ae76479 New changeset b1303cf15e01 by Antoine Pitrou in branc

[issue14172] ref-counting leak in buffer usage in Python/marshal.c

Changes by Antoine Pitrou : -- stage: -> patch review versions: -Python 3.1 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue14172] ref-counting leak in buffer usage in Python/marshal.c

Antoine Pitrou added the comment: Here is a patch. -- keywords: +patch nosy: +pitrou, skrah Added file: http://bugs.python.org/file24708/marshalbufs.patch ___ Python tracker ___

[issue14172] ref-counting leak in buffer usage in Python/marshal.c

New submission from Stefan Behnel : Line 428 in Python/marshal.c calls pb->bf_releasebuffer() without dec-refing the view.obj field afterwards. I don't think this is really so truly performance critical that it can't accept the couple of nanoseconds that it takes to go through PyBuffer_Release