Martin v. Löwis added the comment:
Thanks for the effort, but I'm rejecting this now. I'm not fundamentally
opposed to restructing this code, but I do think that your change would be a
slight loss of readability. If you absolutely cannot stand working with such a
large code, please try to fin
Merlijn van Deen added the comment:
See https://bitbucket.org/valhallasw/cpython/src/ee0d2beaf6a4/Modules/_pickle.c
for a rough structure overview - which maybe also explains why I thought
restructuring made sense in the first place.
However, I'm not the person who has to maintain the module.
Martin v. Löwis added the comment:
I'm -1 on splitting the file. This is C, splitting it up will make it *harder*
to understand, as you have to search across multiple files to find anything.
If you want to make it more readable, I propose that you
a) put a comment in the top explaining how the
Merlijn van Deen added the comment:
That makes sense. The goal was not so much cleaning up the module per se;
rather, it was a result of trying to understand the general structure of
_pickler.c specifically.
However, is there an intermediate level of 'modularization' you would propose?
The i
Antoine Pitrou added the comment:
I think this is going overboard. _pickle.c is long but it defines two classes
which are closely related to each other. I don't really get the point of
exploding it into a myriad of 30-line files, especially if it means I now have
to keep all these tiny files
New submission from Merlijn van Deen :
While working on #6784, I've looked at _pickle.c and found it quite...
daunting: 6500 lines and 185kB. I have been working on a bit of cleanup, and
I'd like some comments on this.
I'm working on adapting
_pickle.c into the following structure:
_pickle.c
