[issue14053] Make patchcheck work with MQ

Nadeem Vawda added the comment: Committed. Thanks for the patch! > I haven't added NEWS as I thing is easier for the person that applies the > patch to simply write the line directly there instead of merging. Is that ok? Yes, that's fine; usually the NEWS entry is more or less the same as the

[issue14053] Make patchcheck work with MQ

Roundup Robot added the comment: New changeset 179bc7557484 by Nadeem Vawda in branch '2.7': Issue #14053: Fix "make patchcheck" to work with MQ. http://hg.python.org/cpython/rev/179bc7557484 New changeset fc5de19c66e2 by Nadeem Vawda in branch '3.2': Issue #14053: Fix "make patchcheck" to work

[issue14053] Make patchcheck work with MQ

Francisco Martín Brugué added the comment: Ok! I haven't added NEWS as I thing is easier for the person that applies the patch to simply write the line directly there instead of merging. Is that ok? let me know if something has to be improved. Thanks again for your mentoring this! -

[issue14053] Make patchcheck work with MQ

Nadeem Vawda added the comment: Patch looks good; I've just got one more small suggestion. The variable 'some_applied' in mq_patches_applied isn't really necessary - it would be clearer if you just said: return st.returncode == 0 and bstdout after the call to st.communicate(). > Interes

[issue14053] Make patchcheck work with MQ

Francisco Martín Brugué added the comment: Updated. Interesting: I saw that repetition but due “[…] Ideally, it should distinguish between this and other errors by checking the subprocess's stderr, so that if a different error occurs, we can still print out the error message. […]” I just wanted

[issue14053] Make patchcheck work with MQ

Changes by Éric Araujo : -- title: Make Tools/scripts/patchcheck.py compatible with mercurial mqueues. -> Make patchcheck work with MQ ___ Python tracker ___ ___