[issue14053] Make Tools/scripts/patchcheck.py compatible with mercurial mqueues.

2012-02-20 Thread Nadeem Vawda
Nadeem Vawda added the comment: Hmm... it looks like mq_changed_files() duplicates a chunk of logic from the existing changed_files() code. You can get rid of this redundancy by replacing mq_changed_files() with a function that checks for applied MQ patches; let's call it mq_patches_applied(). T

[issue14053] Make Tools/scripts/patchcheck.py compatible with mercurial mqueues.

2012-02-20 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: The patch is updated. Notice about: [...]Ideally, it should distinguish between this and other errors by checking the subprocess's stderr, so that if a different error occurs, we can still print out the error message. […] that should be improved a

[issue14053] Make Tools/scripts/patchcheck.py compatible with mercurial mqueues.

2012-02-20 Thread Nadeem Vawda
Nadeem Vawda added the comment: > Shouldn't be --rev qparent ? Yes, that's right. I seem to confuse qbase and qparent often... -- ___ Python tracker ___ ___

[issue14053] Make Tools/scripts/patchcheck.py compatible with mercurial mqueues.

2012-02-20 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: Nice feedback ! One question : > >An alternative approach that solves all three of these problems is to >check whether we have any patches applied (using "hg qapplied"), and if >this is the case, then add "--rev qbase" to the "hg status" c

[issue14053] Make Tools/scripts/patchcheck.py compatible with mercurial mqueues.

2012-02-19 Thread Nadeem Vawda
Nadeem Vawda added the comment: Thanks for taking this up; it's something that's been bothering me for a while now. A couple of comments: - The mq_changed_files() function will break if the user has specified git-format diffs in their ~/.hgrc file. In this case, the diff command in the out

[issue14053] Make Tools/scripts/patchcheck.py compatible with mercurial mqueues.

2012-02-19 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: Here is a patch that works for me. Please check and review it. Thanks in advance! Francis -- keywords: +patch Added file: http://bugs.python.org/file24566/issue14053_336a614f35a3.patch ___ Python tracker

[issue14053] Make Tools/scripts/patchcheck.py compatible with mercurial mqueues.

2012-02-19 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +eric.araujo versions: +Python 2.7, Python 3.2, Python 3.3 ___ Python tracker ___ ___ Python-bugs

[issue14053] Make Tools/scripts/patchcheck.py compatible with mercurial mqueues.

2012-02-19 Thread Nadeem Vawda
Changes by Nadeem Vawda : -- nosy: +nadeem.vawda ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue14053] Make Tools/scripts/patchcheck.py compatible with mercurial mqueues.

2012-02-19 Thread Francisco Martín Brugué
New submission from Francisco Martín Brugué : The devguide (http://docs.python.org/devguide/patch.html) recommends the use of the mercurial “mq” feature to work with patches and that works IMHO very well. It also states that before sending the patch a sanity check should be done ('devguide: Pr