[issue14026] test_cmd_line_script should include more sys.argv checks

Changes by Nick Coghlan : -- resolution: -> fixed stage: test needed -> committed/rejected status: open -> closed versions: -Python 2.7 ___ Python tracker ___ _

[issue14026] test_cmd_line_script should include more sys.argv checks

Roundup Robot added the comment: New changeset 22f0044ea366 by Nick Coghlan in branch '3.2': Close issue #14026 by better testing sys.argv handling in test_cmd_line_script (patch by Jason Yeo) http://hg.python.org/cpython/rev/22f0044ea366 New changeset ff6593aa8376 by Nick Coghlan in branch 'd

[issue14026] test_cmd_line_script should include more sys.argv checks

Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue14026] test_cmd_line_script should include more sys.argv checks

Changes by Nick Coghlan : -- assignee: -> ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue14026] test_cmd_line_script should include more sys.argv checks

Éric Araujo added the comment: I saw nothing wrong. Give Nick a week to find time to review :) -- ___ Python tracker ___ ___ Python-

[issue14026] test_cmd_line_script should include more sys.argv checks

Jason Yeo added the comment: *friendly ping*, how's the review for this patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue14026] test_cmd_line_script should include more sys.argv checks

Changes by Jason Yeo : -- keywords: +patch Added file: http://bugs.python.org/file24588/14026v2.patch ___ Python tracker ___ ___ Pytho

[issue14026] test_cmd_line_script should include more sys.argv checks

Changes by Jason Yeo : Removed file: http://bugs.python.org/file24556/14026patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue14026] test_cmd_line_script should include more sys.argv checks

Changes by Jason Yeo : Removed file: http://bugs.python.org/file24587/mypatch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue14026] test_cmd_line_script should include more sys.argv checks

Jason Yeo added the comment: >For the two failures, I suggest modifying _check_script() to return the >"rc, out, err" from the underlying assert_python_ok() call I've decided to simple pass in *example_args into the assert_python_ok() in those two offending tests. There are less changes this

[issue14026] test_cmd_line_script should include more sys.argv checks

Nick Coghlan added the comment: The second instance is inside the source code string that's written out as the script to be run in the subprocess. Not a bad idea actually: - it avoids writing the example args twice (which is what I was thinking of doing) - it avoids turning the test_script int

[issue14026] test_cmd_line_script should include more sys.argv checks

Éric Araujo added the comment: I don’t understand why you import the module inside the same module. -- ___ Python tracker ___ ___ Pyt

[issue14026] test_cmd_line_script should include more sys.argv checks

Jason Yeo added the comment: >Just define a list of example args as a module global, append them to >the run_args in _check_script, and check them against sys.argv[1:] with >assertEqual() in the test script. Okay I have done that but the assertion passes in all the tests except in test_issue

[issue14026] test_cmd_line_script should include more sys.argv checks

Nick Coghlan added the comment: For the purposes of this test (i.e. running the same script several different ways and making sure it always behaves as expected), I wouldn't even worry about making it configurable. Just define a list of example args as a module global, append them to the run

[issue14026] test_cmd_line_script should include more sys.argv checks

Changes by Éric Araujo : -- Removed message: http://bugs.python.org/msg153560 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue14026] test_cmd_line_script should include more sys.argv checks

Éric Araujo added the comment: > It seems that the method signature for _check_script has to be changed > in include another parameter for expected_argv1, expected_argv2, It would seem simpler to me to make that expected_argv :) -- ___ Python tracker

[issue14026] test_cmd_line_script should include more sys.argv checks

Éric Araujo added the comment: > It seems that the method signature for _check_script has to be changed > in include another parameter for expected_argv1, expected_argv2, It would seem simpler to me to make that expected_argv. -- ___ Python tracker

[issue14026] test_cmd_line_script should include more sys.argv checks

Jason Yeo added the comment: I would like to work on this but I am not sure how to go about it. It seems that the method signature for _check_script has to be changed in include another parameter for expected_argv1, expected_argv2, etc. The _check_output also has to be changed to include asse

[issue14026] test_cmd_line_script should include more sys.argv checks

Changes by Jason Yeo : -- nosy: +Jason.Yeo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue14026] test_cmd_line_script should include more sys.argv checks

Changes by Éric Araujo : -- nosy: +eric.araujo stage: -> test needed type: -> enhancement versions: +Python 2.7, Python 3.2 ___ Python tracker ___ _

[issue14026] test_cmd_line_script should include more sys.argv checks

New submission from Nick Coghlan : Currently, test_cmd_line_script only checks sys.argv[0] is set correctly. It should pass some extra values after the script name, then include an appropriate check in the output of the launched script. -- components: Tests keywords: easy messages: 153