[issue13918] locale.atof documentation is missing func argument

Georg Brandl added the comment: And the first quote is wrong. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13918] locale.atof documentation is missing func argument

Antoine Pitrou added the comment: Ah, right, thank you. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue13918] locale.atof documentation is missing func argument

STINNER Victor added the comment: +:const:'LC_NUMERIC`settings. a space is missing before "settings", no? -- nosy: +haypo ___ Python tracker ___

[issue13918] locale.atof documentation is missing func argument

Antoine Pitrou added the comment: Done. Thank you for your contribution! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue13918] locale.atof documentation is missing func argument

Roundup Robot added the comment: New changeset aee097e5a2b2 by Antoine Pitrou in branch 'default': Issue #13918: Provide a locale.delocalize() function which can remove https://hg.python.org/cpython/rev/aee097e5a2b2 -- nosy: +python-dev ___ Python tra

[issue13918] locale.atof documentation is missing func argument

Antoine Pitrou added the comment: Thank you! The patch looks good to me, I'm going to apply it. -- ___ Python tracker ___ ___ Python-b

[issue13918] locale.atof documentation is missing func argument

Cédric Krier added the comment: Add return value is string in doc Add versionadded And yes I signed the agreement. -- Added file: http://bugs.python.org/file36964/delocalize.patch ___ Python tracker ___

[issue13918] locale.atof documentation is missing func argument

Antoine Pitrou added the comment: Thanks for the updated patch, Cédric. Just some remarks: - the documentation should mention that the return value is still a string - the documentation needs a "versionadded" marker next to the new function - have you already signed the contributor's agreement?

[issue13918] locale.atof documentation is missing func argument

Cédric Krier added the comment: A new version with unittest. -- Added file: http://bugs.python.org/file36960/delocalize.patch ___ Python tracker ___ _

[issue13918] locale.atof documentation is missing func argument

Antoine Pitrou added the comment: The patch's approach looks reasonable to me. -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs

[issue13918] locale.atof documentation is missing func argument

Changes by Antoine Pitrou : -- assignee: docs@python -> components: +Library (Lib) -Documentation stage: -> patch review versions: +Python 3.5 -Python 2.7, Python 3.2, Python 3.3, Python 3.4 ___ Python tracker __

[issue13918] locale.atof documentation is missing func argument

Cédric Krier added the comment: So what about this patch? It adds a delocalize method while keeping the atof func parameter for backward compatibility. -- Added file: http://bugs.python.org/file36955/delocalize.patch ___ Python tracker

[issue13918] locale.atof documentation is missing func argument

Changes by Stefan Krah : -- nosy: -skrah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.o

[issue13918] locale.atof documentation is missing func argument

Ezio Melotti added the comment: It's easier, but we will be exposing an API that is not too elegant IMHO. The refactoring could provide a better API, but OTOH it will make it available for 3.4+ only, and it would break backward compatibility if the old API is removed (even though it's not doc

[issue13918] locale.atof documentation is missing func argument

Terry J. Reedy added the comment: The refactoring could be done if we were willing to give the normalize function a public name, so people could write Decimal(delocalize()) or if we were willing to add atod and atofr (fraction). However, simply adding a few words to the doc is a lot easier. --

[issue13918] locale.atof documentation is missing func argument

Ezio Melotti added the comment: The function was introduced by Guido in f5b55311e79d. I think it would have been better if atof had another name (e.g. _atof) and that atof and atoi were implemented as: def atof(str): return _atof(str, float) def atoi(str): return _atof(str, int) Even

[issue13918] locale.atof documentation is missing func argument

Terry J. Reedy added the comment: I find the idea of intentionally not documenting a public parameter and the full signature of a function somewhat strange, especially when it is already automatically partially-documented. >>> import locale >>> help(locale.atof) Help on function atof in module

[issue13918] locale.atof documentation is missing func argument

Cédric Krier added the comment: Here is a patch for the documentation. -- keywords: +patch resolution: wont fix -> Added file: http://bugs.python.org/file29414/doc_atof.patch ___ Python tracker ___

[issue13918] locale.atof documentation is missing func argument

Stefan Krah added the comment: Cédric Krier wrote: > locale.atof is not about formatting but parsing string into float following > the locale. You're right. Sorry, I never use these locale functions. My impression is that locales are often buggy or differ across platforms (see #16944). So act

[issue13918] locale.atof documentation is missing func argument

Cédric Krier added the comment: locale.atof is not about formatting but parsing string into float following the locale. For now, the only ways I see to parse a string to get a Decimal is to first convert it into float (which is not good if precision matters) or to use the undocumented paramete

[issue13918] locale.atof documentation is missing func argument

Stefan Krah added the comment: I agree with "won't fix" for the original issue. These locale functions are in effect superseded by PEP 3101 formatting. For decimal locale specific formatting, use: format(Decimal("1729.1415927"), "n") IOW, I don't think new formatting functions should be added

[issue13918] locale.atof documentation is missing func argument

Changes by Ezio Melotti : -- nosy: +mark.dickinson, skrah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue13918] locale.atof documentation is missing func argument

Cédric Krier added the comment: Then I think we miss a locale.atod to parse string to Decimal -- status: pending -> open ___ Python tracker ___ __

[issue13918] locale.atof documentation is missing func argument

Ezio Melotti added the comment: It looks like an implementation detail to me, so I tend to agree with Georg. I'm not sure if this should be noted in the code though. -- nosy: +ezio.melotti status: open -> pending ___ Python tracker

[issue13918] locale.atof documentation is missing func argument

Cédric Krier added the comment: Indeed I find it useful to use to get a Decimal instead of a float. So I was wondering if I can rely on it or not in my application? -- status: pending -> open ___ Python tracker __

[issue13918] locale.atof documentation is missing func argument

Georg Brandl added the comment: I don't think that argument needs to be documented. It's just there because somebody thought that copying 3 lines from atof into atoi was a bad idea. -- nosy: +georg.brandl resolution: -> wont fix status: open -> pending __

[issue13918] locale.atof documentation is missing func argument

New submission from Cédric Krier : atof has a func argument used to instantiate the result but it is missing in the documentation. -- assignee: docs@python components: Documentation messages: 152430 nosy: ced, docs@python priority: normal severity: normal status: open title: locale.atof