[issue13896] Make shelf instances work with 'with' as context managers

2013-01-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: The patch did not update the doc. See #17040, with proposed patch. -- ___ Python tracker ___ ___ Pyt

[issue13896] Make shelf instances work with 'with' as context managers

2012-10-06 Thread Andrew Svetlov
Andrew Svetlov added the comment: Committed. Thanks. Please fill Python Contributor Agreement: http://www.python.org/psf/contrib/ -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue13896] Make shelf instances work with 'with' as context managers

2012-10-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3c1df1ede882 by Andrew Svetlov in branch 'default': Issue #13896: Make shelf instances work with 'with' as context managers. http://hg.python.org/cpython/rev/3c1df1ede882 -- nosy: +python-dev ___ Python t

[issue13896] Make shelf instances work with 'with' as context managers

2012-10-05 Thread Filip Gruszczyński
Filip Gruszczyński added the comment: Crap, it was so long ago, that I honestly don't remember why I added this if. It made sense back then. -- ___ Python tracker ___ __

[issue13896] Make shelf instances work with 'with' as context managers

2012-10-05 Thread Andrew Svetlov
Changes by Andrew Svetlov : -- assignee: -> asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue13896] Make shelf instances work with 'with' as context managers

2012-10-05 Thread Andrew Svetlov
Andrew Svetlov added the comment: Filip, please describe why you prevent closing if writeback attribute is not present. I see comment for __del__ related to #1339007, but at __exit__ call __enter__ has called already and __init__ has finished definitely with success. Also I would to see referen

[issue13896] Make shelf instances work with 'with' as context managers

2012-09-26 Thread Andrew Svetlov
Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue13896] Make shelf instances work with 'with' as context managers

2012-09-10 Thread Berker Peksag
Changes by Berker Peksag : -- versions: +Python 3.4 -Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13896] Make shelf instances work with 'with' as context managers

2012-09-05 Thread Miguel Angel García
Changes by Miguel Angel García : -- nosy: +Miguel.Angel.García ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13896] Make shelf instances work with 'with' as context managers

2012-02-04 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- stage: test needed -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue13896] Make shelf instances work with 'with' as context managers

2012-02-04 Thread Filip Gruszczyński
Filip Gruszczyński added the comment: closing was solving my problem, but I'll be happy on working on this patch, if you think it's useful after all. I don't think the stage should be test needed, since the patch has tests (I know the drill here ;-)). -- _

[issue13896] Make shelf instances work with 'with' as context managers

2012-02-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: contextlib.closing is an adapter for using objects that have a close method but have not be modernized to be context managers by having _enter__ and __exit__ methods added. Its doc gives the example with closing(urlopen('http://www.python.org')) as page: This