[issue13874] test_faulthandler: read_null test fails with current clang

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue13874] test_faulthandler: read_null test fails with current clang

Stefan Krah added the comment: STINNER Victor wrote: > Does my commit fix the issue? Yes, perfectly. -- ___ Python tracker ___ ___

[issue13874] test_faulthandler: read_null test fails with current clang

STINNER Victor added the comment: Does my commit fix the issue? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue13874] test_faulthandler: read_null test fails with current clang

Roundup Robot added the comment: New changeset f71249d785d6 by Victor Stinner in branch 'default': Issue #13874: read_null() of faulthandler uses volatile to avoid optimisation http://hg.python.org/cpython/rev/f71249d785d6 -- nosy: +python-dev ___ Py

[issue13874] test_faulthandler: read_null test fails with current clang

Jesús Cea Avión added the comment: Nothing. I just read the sourcecode :-). I would add an "y=0" in the declaration too, just for aestetics. -- ___ Python tracker ___ _

[issue13874] test_faulthandler: read_null test fails with current clang

Stefan Krah added the comment: Jes??s Cea Avi??n wrote: > That makes "x" and "y" volatile. Well yes, but is that a problem? -- ___ Python tracker ___ _

[issue13874] test_faulthandler: read_null test fails with current clang

Jesús Cea Avión added the comment: That makes "x" and "y" volatile. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue13874] test_faulthandler: read_null test fails with current clang

Stefan Krah added the comment: Well, to be completely unambiguous. This works: diff -r d2cf8a34ddf9 Modules/faulthandler.c --- a/Modules/faulthandler.cThu Jan 26 00:15:07 2012 -0800 +++ b/Modules/faulthandler.cFri Jan 27 23:16:27 2012 +0100 @@ -943,7 +943,7 @@ static PyObject * faulth

[issue13874] test_faulthandler: read_null test fails with current clang

Stefan Krah added the comment: Yes, volatile works, too. That's probably the best solution. -- ___ Python tracker ___ ___ Python-bugs

[issue13874] test_faulthandler: read_null test fails with current clang

STINNER Victor added the comment: Oh, you can also try something else: add the volatile keyword. -- ___ Python tracker ___ ___ Python

[issue13874] test_faulthandler: read_null test fails with current clang

Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue13874] test_faulthandler: read_null test fails with current clang

STINNER Victor added the comment: There was a similar bug which was declared as a vulnerability in the Linux kernel: http://isc.sans.edu/diary.html?storyid=6820 GCC has an option to disable this optimization: -fno-delete-null-pointer-checks. -- ___

[issue13874] test_faulthandler: read_null test fails with current clang

Stefan Krah added the comment: STINNER Victor wrote: > Can you try x = (int *)1; instead of x = NULL; ? This works. - I must say that I find this new behavior of clang slightly dangerous... -- ___ Python tracker

[issue13874] test_faulthandler: read_null test fails with current clang

STINNER Victor added the comment: Can you try x = (int *)1; instead of x = NULL; ? -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue13874] test_faulthandler: read_null test fails with current clang

New submission from Stefan Krah : In non-debug mode the read_null test fails with clang-3.0: == FAIL: test_disable (test.test_faulthandler.FaultHandlerTests) --