[issue13783] Clean up PEP 380 C API additions

Nick Coghlan added the comment: I left the name of the new private API as _PyGen_FetchStopIterationValue. If anyone wants to make it public, they can raise a new issue to give it a more appropriate name (and move the definition accordingly). PyStopIteration_Create is simply gone, replaced by

[issue13783] Clean up PEP 380 C API additions

Roundup Robot added the comment: New changeset 438b861e2edb by Nick Coghlan in branch 'default': Issue #13783: PEP 380 cleanup part 2, using the new identifier APIs in the generator implementation http://hg.python.org/cpython/rev/438b861e2edb -- ___

[issue13783] Clean up PEP 380 C API additions

Roundup Robot added the comment: New changeset cfbf6aa5c9e3 by Nick Coghlan in branch 'default': Issue #13783: the PEP 380 implementation no longer expands the public C API http://hg.python.org/cpython/rev/cfbf6aa5c9e3 -- nosy: +python-dev ___ Python

[issue13783] Clean up PEP 380 C API additions

Mark Shannon added the comment: There is one call to PyGen_FetchStopIterationValue in ceval.c. But I don't think it should be public. There is no real reason for the "Gen" in the name. The function is used by generator handling code, but the code itself relates to StopIteration. Perhaps it s

[issue13783] Clean up PEP 380 C API additions

Changes by Nick Coghlan : -- assignee: docs@python -> ncoghlan priority: normal -> release blocker ___ Python tracker ___ ___ Python-b

[issue13783] Clean up PEP 380 C API additions

Meador Inge added the comment: 'PyStopIteration_Create' is just a trivial wrapper: PyObject * PyStopIteration_Create(PyObject *value) { return PyObject_CallFunctionObjArgs(PyExc_StopIteration, value, NULL); } It is not needed. As for 'PyGen_FetchStopIterationValue', does it really need to

[issue13783] Clean up PEP 380 C API additions

Nick Coghlan added the comment: Also check any GetAttr and CallMethod operations to see if they should be moved over to the new *Id variants. -- ___ Python tracker ___

[issue13783] Clean up PEP 380 C API additions

Nick Coghlan added the comment: The current use of PyStopIteration_Create in genobject.c can probably be replaced with PyErr_SetObject(PyExc_StopIteration, value) anyway. -- ___ Python tracker ___

[issue13783] Clean up PEP 380 C API additions

New submission from Nick Coghlan : Georg noted that the PEP 380 patch added a couple of new C interfaces without documenting them. These interfaces need to be either: 1. Documented; 2. Made private; or 3. Removed (if they're completely trivial) PyGen_FetchStopIterationValue: probably document,