[issue13773] Support sqlite3 uri filenames

Serhiy Storchaka added the comment: Oh, I were blind. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue13773] Support sqlite3 uri filenames

Antoine Pitrou added the comment: > You can use "p" format in PyArg_ParseTuple* for boolean parameters. That's what I used, indeed. -- ___ Python tracker ___ ___

[issue13773] Support sqlite3 uri filenames

Serhiy Storchaka added the comment: You can use "p" format in PyArg_ParseTuple* for boolean parameters. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue13773] Support sqlite3 uri filenames

Antoine Pitrou added the comment: I've committed the patch, closing. -- assignee: ghaering -> resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker _

[issue13773] Support sqlite3 uri filenames

Roundup Robot added the comment: New changeset f13bb1e40fbc by Antoine Pitrou in branch 'default': Issue #13773: sqlite3.connect() gets a new `uri` parameter to pass the filename as a URI, allowing to pass custom options. http://hg.python.org/cpython/rev/f13bb1e40fbc -- nosy: +python-de

[issue13773] Support sqlite3 uri filenames

Antoine Pitrou added the comment: Here is an updated patch. -- Added file: http://bugs.python.org/file28982/sqlite_open_uri.patch ___ Python tracker ___ _

[issue13773] Support sqlite3 uri filenames

Antoine Pitrou added the comment: This would definitely be useful. I would have liked to have this feature today. poq, could you sign a contributor agreement? See http://www.python.org/psf/contrib/ Also, it's better if you can use a real name (or at least a well-known pseudonym). -- __

[issue13773] Support sqlite3 uri filenames

Changes by Antoine Pitrou : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue13773] Support sqlite3 uri filenames

Éric Araujo added the comment: 2.7 and 3.2 are stable versions which only get bug fixes. 3.3 is in release candidate stage, so this new feature can only go into 3.4. See the devguide and PEPs for more info about the process we follow. -- versions: +Python 3.4 -Python 3.3 ___

[issue13773] Support sqlite3 uri filenames

André Anjos added the comment: A question concerning this patch: is this going to be applied only to 3.3 or to 2.7 as well? Python-2.7.x also does not have this functionality which would be interesting to get. -- nosy: +anjos ___ Python tracker

[issue13773] Support sqlite3 uri filenames

Éric Araujo added the comment: > I've added an updated patch which adds a link. I've also changed the > exception when URIs > are not supported to sqlite3.NotSupportedError. Sounds good. Note to the person who will commit: :const:`True` should be marked up as ``True.`` > I prefer anonymity.

[issue13773] Support sqlite3 uri filenames

poq added the comment: > The Python docs should either list them (there aren’t much; pro: all the info > is here, con: maintenance) or link to them. They've already added a new option ('psow') since I opened this report, so linking is probably more future-proof. I've added an updated patch w

[issue13773] Support sqlite3 uri filenames

Éric Araujo added the comment: [Amaury] > The test function should use "from test.support import TESTFN" to get > a temporary file name I believe that TESTFN predates tempfile (and the tempfile helpers in regrtest and test.support) and is now seen as an ugly relic (at least by me :) [poq] >> I

[issue13773] Support sqlite3 uri filenames

poq added the comment: > Can you open a bug report for that? Opened #13934. > I think the doc could link to the sqlite.org doc about URIs. I considered this, but the rest of the sqlite3 module documentation doesn't link to the sqlite.org doc pages either. There is only a link to http://www.

[issue13773] Support sqlite3 uri filenames

Éric Araujo added the comment: > Should I also rewrap modified lines that were already much too long? Please don’t, it would make the diff harder to read. > I also noticed & fixed an unrelated typo in Lib/sqlite3/test/hooks.py... Can you open a bug report for that? I think the doc could link t

[issue13773] Support sqlite3 uri filenames

Changes by Éric Araujo : -- assignee: -> ghaering nosy: +eric.araujo, ghaering ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue13773] Support sqlite3 uri filenames

poq added the comment: Thanks for your comments. You're right, I didn't consider positional arguments. Here's a patch that addresses your comments. Should I also rewrap modified lines that were already much too long? I also noticed & fixed an unrelated typo in Lib/sqlite3/test/hooks.py... --

[issue13773] Support sqlite3 uri filenames

Amaury Forgeot d'Arc added the comment: Hi, I will let others discuss the feature itself, here are already some comments about your patch: - In module_connect(), the ability to pass "factory" as a positional argument is broken, please restore the previous code; I'm afraid there is no better

[issue13773] Support sqlite3 uri filenames

New submission from poq : URIs are an extensible way to pass options to SQLite. See: http://www.sqlite.org/uri.html Patch adds a keyword argument "uri" to sqlite3.connect which causes the filename to be parsed as a URI if set to True. -- components: Extension Modules files: sqlite-uri.