[issue13611] Integrate ElementC14N module into xml.etree package

Stefan Behnel added the comment: > Maybe complete Doc/license.rst? Thanks, done. -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue13611] Integrate ElementC14N module into xml.etree package

Change by Stefan Behnel : -- pull_requests: +12972 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue13611] Integrate ElementC14N module into xml.etree package

STINNER Victor added the comment: > Is there anything else I have to take care of when adding externally > provided/licensed files to the source tree? Maybe complete Doc/license.rst? https://docs.python.org/dev/license.html -- ___ Python tracker

[issue13611] Integrate ElementC14N module into xml.etree package

Stefan Behnel added the comment: A buildbot failure made me notice that the test files were not part of the CPython installation yet, so I added them. I also took the opportunity to add a README file that describes where they come from and under which conditions they were originally provided

[issue13611] Integrate ElementC14N module into xml.etree package

Stefan Behnel added the comment: New changeset 0d5864fa07ab4f03188c690a5eb07bdd1fd1cb9c by Stefan Behnel in branch 'master': bpo-13611: Include C14N 2.0 test data in installation (GH-13053) https://github.com/python/cpython/commit/0d5864fa07ab4f03188c690a5eb07bdd1fd1cb9c -- ___

[issue13611] Integrate ElementC14N module into xml.etree package

Change by Stefan Behnel : -- pull_requests: +12971 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue13611] Integrate ElementC14N module into xml.etree package

Change by Stefan Behnel : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue13611] Integrate ElementC14N module into xml.etree package

Stefan Behnel added the comment: New changeset e1d5dd645d5f59867cb0ad63179110f310cbca89 by Stefan Behnel in branch 'master': bpo-13611: C14N 2.0 implementation for ElementTree (GH-12966) https://github.com/python/cpython/commit/e1d5dd645d5f59867cb0ad63179110f310cbca89 -- __

[issue13611] Integrate ElementC14N module into xml.etree package

Stefan Behnel added the comment: Thanks for testing, Zackery. I resolved the reference leaks. They were already in the PR for issue 36676. Both PRs updated. -- ___ Python tracker ___

[issue13611] Integrate ElementC14N module into xml.etree package

Zackery Spytz added the comment: The PR has reference leaks. -- nosy: +ZackerySpytz ___ Python tracker ___ ___ Python-bugs-list mai

[issue13611] Integrate ElementC14N module into xml.etree package

Stefan Behnel added the comment: > I personally think it's ready to go into the last alpha release Since I didn't get any negative comments or requests for deferral, I'll merge this today to get the feature into the last (still unreleased) alpha. We still have the beta phase to resolve issue

[issue13611] Integrate ElementC14N module into xml.etree package

Stefan Behnel added the comment: Playing around with it a bit more, I ended up changing the interface of the canonicalize() function to return its output as a string by default. It's really nice to be able to say c14n_xml = canonicalize(plain_xml) To write to a file, you now do this:

[issue13611] Integrate ElementC14N module into xml.etree package

Stefan Behnel added the comment: It took me a couple of minutes longer to submit it, but it's there now. :) I'm aware that there is a lot of new code involved, covering really three new features, which makes reviewing it a non-trivial task. I personally think it's ready to go into the last a

[issue13611] Integrate ElementC14N module into xml.etree package

STINNER Victor added the comment: > Comments and reviews welcome. Review of what? There is no PR attached to this issue. -- nosy: +vstinner ___ Python tracker ___ ___

[issue13611] Integrate ElementC14N module into xml.etree package

Change by Stefan Behnel : -- keywords: +patch pull_requests: +12893 stage: needs patch -> patch review ___ Python tracker ___ ___ Py

[issue13611] Integrate ElementC14N module into xml.etree package

Stefan Behnel added the comment: Turns out, it was not that easy. :-/ ElementTree lacks prefixes in its tree model, so they would have to be either registered globally (via register_namespace()) or come from the parser. I tried the latter since that is the most generic way when the input is

[issue13611] Integrate ElementC14N module into xml.etree package

Serhiy Storchaka added the comment: References: Canonical XML Version 2.0 -- https://www.w3.org/TR/xml-c14n2/ Test cases for Canonical XML 2.0 -- https://www.w3.org/TR/xml-c14n2-testcases/ -- ___ Python tracker

[issue13611] Integrate ElementC14N module into xml.etree package

Change by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13611] Integrate ElementC14N module into xml.etree package

Serhiy Storchaka added the comment: "c14n" is documented as an accepted serialization method of write() and there is some (non-working) code for support of C14N. e6a951b83e30b3b9c809a441041fb0f21f72b168 removed optional import of ElementC14N. -- _

[issue13611] Integrate ElementC14N module into xml.etree package

Change by Serhiy Storchaka : -- nosy: +serhiy.storchaka stage: -> needs patch versions: +Python 3.8 -Python 3.4 ___ Python tracker ___

[issue13611] Integrate ElementC14N module into xml.etree package

Changes by Antoine Pitrou : -- nosy: +eli.bendersky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue13611] Integrate ElementC14N module into xml.etree package

Chris E added the comment: Whilst in most cases this would be correct, in this case it looks like the original contributor took a subset of what the original author wrote and put it into the python libraries. Until relatively recently the ElementTree.py file included a stanza that attempted t

[issue13611] Integrate ElementC14N module into xml.etree package

Changes by Christian Heimes : -- nosy: +christian.heimes, effbot versions: +Python 3.4 -Python 3.3 ___ Python tracker ___ ___ Python-b

[issue13611] Integrate ElementC14N module into xml.etree package

Martin v. Löwis added the comment: Code added to the standard library should be contributed by its author, with an explicit statement of plans to support it in an ongoing manner, and preferably also with plans to stop providing standalone releases over time. -- nosy: +loewis

[issue13611] Integrate ElementC14N module into xml.etree package

Changes by Antoine Pitrou : -- nosy: +flox ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue13611] Integrate ElementC14N module into xml.etree package

New submission from Stefan Behnel : The ElementC14N.py module by Fredrik Lundh implements XML canonicalisation for the ElementTree serialiser. Given that the required API hooks to use it are already in xml.etree.ElementTree, this would make a nice, simple and straight forward addition to the e