[issue13588] Change name of internal closure functions in importlib

2012-02-06 Thread Brett Cannon
Changes by Brett Cannon : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue13588] Change name of internal closure functions in importlib

2012-01-16 Thread Brett Cannon
Brett Cannon added the comment: Thanks for the patch, Berker! It's all committed. -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue13588] Change name of internal closure functions in importlib

2012-01-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9935f7837c4b by Brett Cannon in branch 'default': Issue #13588: Rename decorators in importlib. http://hg.python.org/cpython/rev/9935f7837c4b -- nosy: +python-dev ___ Python tracker

[issue13588] Change name of internal closure functions in importlib

2012-01-16 Thread Brett Cannon
Brett Cannon added the comment: Sorry, been busy. I will definitely get to it this week. On Sun, Jan 15, 2012 at 19:58, Berker Peksag wrote: > > Berker Peksag added the comment: > > Hi Brett, did you have a chance to review the patch I submitted? > > -- > > __

[issue13588] Change name of internal closure functions in importlib

2012-01-15 Thread Berker Peksag
Berker Peksag added the comment: Hi Brett, did you have a chance to review the patch I submitted? -- ___ Python tracker ___ ___ Pytho

[issue13588] Change name of internal closure functions in importlib

2011-12-14 Thread Brett Cannon
Brett Cannon added the comment: Thanks for the patch! I will try to find some time to do a proper review if someone else doesn't beat me to it (although first glance seems to suggest it all looks fine). -- stage: needs patch -> patch review ___ Pyt

[issue13588] Change name of internal closure functions in importlib

2011-12-13 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +patch Added file: http://bugs.python.org/file23947/issue13588_v1.diff ___ Python tracker ___

[issue13588] Change name of internal closure functions in importlib

2011-12-12 Thread Eric Snow
Changes by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue13588] Change name of internal closure functions in importlib

2011-12-12 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berkerpeksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue13588] Change name of internal closure functions in importlib

2011-12-12 Thread Brett Cannon
New submission from Brett Cannon : The internal closure functions (eg. wrapper functions used by decorators) should not use generic names like inner() or wrapper(), but descriptive names so that they make sense when read in a traceback. IOW, you shouldn't have to look up the source code to fig