[issue13544] Add __qualname__ to functools.WRAPPER_ASSIGNMENTS

2011-12-12 Thread Meador Inge
Meador Inge added the comment: Yup, oversight on my part. Thanks. -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-l

[issue13544] Add __qualname__ to functools.WRAPPER_ASSIGNMENTS

2011-12-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: I suppose the status can be switched to "closed"? -- nosy: +pitrou ___ Python tracker ___ ___ Pytho

[issue13544] Add __qualname__ to functools.WRAPPER_ASSIGNMENTS

2011-12-12 Thread Filip Gruszczyński
Filip Gruszczyński added the comment: Pleasure :-) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue13544] Add __qualname__ to functools.WRAPPER_ASSIGNMENTS

2011-12-11 Thread Meador Inge
Meador Inge added the comment: Thanks for the patch Filip. -- resolution: -> fixed stage: patch review -> committed/rejected type: -> behavior ___ Python tracker ___ _

[issue13544] Add __qualname__ to functools.WRAPPER_ASSIGNMENTS

2011-12-11 Thread Roundup Robot
Roundup Robot added the comment: New changeset 963e98f5ad31 by Meador Inge in branch 'default': Issue #13544: Add __qualname__ to functools.WRAPPER_ASSIGNMENTS. http://hg.python.org/cpython/rev/963e98f5ad31 -- nosy: +python-dev ___ Python tracker

[issue13544] Add __qualname__ to functools.WRAPPER_ASSIGNMENTS

2011-12-11 Thread Meador Inge
Meador Inge added the comment: On Sun, Dec 11, 2011 at 4:42 AM, Nick Coghlan wrote: > Explicitly spelling out __qualname__ like that makes the tests a bit too > sensitive to otherwise irrelevant details of the test layout. > > I suggest using comparisons like "self.assertEqual(wrapper.__qualn

[issue13544] Add __qualname__ to functools.WRAPPER_ASSIGNMENTS

2011-12-11 Thread Filip Gruszczyński
Filip Gruszczyński added the comment: Fixed tests. -- Added file: http://bugs.python.org/file23912/13544_2.patch ___ Python tracker ___ _

[issue13544] Add __qualname__ to functools.WRAPPER_ASSIGNMENTS

2011-12-11 Thread Nick Coghlan
Nick Coghlan added the comment: Explicitly spelling out __qualname__ like that makes the tests a bit too sensitive to otherwise irrelevant details of the test layout. I suggest using comparisons like "self.assertEqual(wrapper.__qualname__, f.__qualname__)" and "self.assertNotEqual(wrapper.__q

[issue13544] Add __qualname__ to functools.WRAPPER_ASSIGNMENTS

2011-12-11 Thread maniram maniram
maniram maniram added the comment: Remove the "needs patch" keyword since this bug has a patch. -- nosy: +maniram.maniram ___ Python tracker ___

[issue13544] Add __qualname__ to functools.WRAPPER_ASSIGNMENTS

2011-12-11 Thread Filip Gruszczyński
Filip Gruszczyński added the comment: I didn't know about `make patchcheck`, next time I will use it, thanks. -- ___ Python tracker ___ _

[issue13544] Add __qualname__ to functools.WRAPPER_ASSIGNMENTS

2011-12-10 Thread Meador Inge
Meador Inge added the comment: Filip, with the exception of some minor whitespace problems (remember to run 'make patchcheck') and a missed testcase in 'TestWraps.test_default_update', this looks good to me. I was just about to attach a similar patch. Here is an updated patch with those mino

[issue13544] Add __qualname__ to functools.WRAPPER_ASSIGNMENTS

2011-12-10 Thread Filip Gruszczyński
Filip Gruszczyński added the comment: Patch with tests. -- keywords: +patch nosy: +gruszczy Added file: http://bugs.python.org/file23906/13544.patch ___ Python tracker ___ _

[issue13544] Add __qualname__ to functools.WRAPPER_ASSIGNMENTS

2011-12-10 Thread Éric Araujo
Changes by Éric Araujo : -- nosy: +eric.araujo, rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue13544] Add __qualname__ to functools.WRAPPER_ASSIGNMENTS

2011-12-06 Thread Nick Coghlan
New submission from Nick Coghlan : functools.update_wrapper() and functools.wraps() should copy the new property by default. -- keywords: easy messages: 148943 nosy: ncoghlan priority: release blocker severity: normal stage: needs patch status: open title: Add __qualname__ to functools.