[issue1349106] email.Generator does not separate headers with "\r\n"

R. David Murray added the comment: Committed in r85811. -- resolution: -> accepted stage: commit review -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue1349106] email.Generator does not separate headers with "\r\n"

R. David Murray added the comment: Removed some debugging cruft from the latest patch. -- Added file: http://bugs.python.org/file19319/email_linesep.patch ___ Python tracker _

[issue1349106] email.Generator does not separate headers with "\r\n"

Changes by R. David Murray : Removed file: http://bugs.python.org/file19318/email_linesep.patch ___ Python tracker ___ ___ Python-bugs-list

[issue1349106] email.Generator does not separate headers with "\r\n"

Changes by R. David Murray : Removed file: http://bugs.python.org/file19291/email_linesep.patch ___ Python tracker ___ ___ Python-bugs-list

[issue1349106] email.Generator does not separate headers with "\r\n"

R. David Murray added the comment: Updated patch that adds a missing test for BytesGenerator.flatten and fixes the bugs in it. Also added versionchanged tags to the docs for the linesep argument. I think this is ready to go in. -- stage: patch review -> commit review Added file: htt

[issue1349106] email.Generator does not separate headers with "\r\n"

Malcolm Box added the comment: David: Great to see a patch for this. You're right of course, 8bit isn't binary - I meant binary. The main place this shows up is when you're using MIME not in email (e.g. on the web), where binary transport is entirely possible. This fix should mean that the

[issue1349106] email.Generator does not separate headers with "\r\n"

R. David Murray added the comment: Malcolm: a Content-Transfer-Encoding of 8bit may only contain \r and \n characters as part of the line ending sequence. 8bit is *not* binary; to use a CTE of binary the SMTP server must support BINARYMIME, which I don't think is all that common yet. At any