[issue13450] add assertions to implement the intent in ''.format_map test

2012-03-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 995cddd15313 by Eric V. Smith in branch '3.2': str.format_map tests don't do what they say: fix to actually implement the intent of the test. Closes #13450. http://hg.python.org/cpython/rev/995cddd15313 New changeset 0df295d590a8 by Eric V. Smith

[issue13450] add assertions to implement the intent in ''.format_map test

2011-11-26 Thread Éric Araujo
Éric Araujo added the comment: When someone puts thought into a report or patch, they deserve to be in Misc/ACKS. Just noticing one typo doesn’t qualify, but pretty much anything above does. :) -- nosy: +eric.araujo versions: -Python 3.4 ___ Pyt

[issue13450] add assertions to implement the intent in ''.format_map test

2011-11-22 Thread akira
akira <4kir4...@gmail.com> added the comment: TypeError tests can check that an implementation raises a correct exception type i.e., it doesn't raise ValueError prematurely on invalid format_string without checking that there is mapping argument. METH_O does it for CPython. I'm not sure how ot

[issue13450] add assertions to implement the intent in ''.format_map test

2011-11-22 Thread Eric V. Smith
Eric V. Smith added the comment: I don't think the existing tests have any value. I might leave one of them, but I think I'll just use your new tests instead. akira: I'd like to add your name to the Misc/ACKS file, if it's not already there. What's your full name? Thanks for the bug report a

[issue13450] add assertions to implement the intent in ''.format_map test

2011-11-21 Thread Eric V. Smith
Changes by Eric V. Smith : -- assignee: -> eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue13450] add assertions to implement the intent in ''.format_map test

2011-11-21 Thread akira
Changes by akira <4kir4...@gmail.com>: Added file: http://bugs.python.org/file23748/correct-assertions-in-test_format_map.patch ___ Python tracker ___ __

[issue13450] add assertions to implement the intent in ''.format_map test

2011-11-21 Thread akira
Changes by akira <4kir4...@gmail.com>: Removed file: http://bugs.python.org/file23747/correct-assertions-in-test_format_map.patch ___ Python tracker ___

[issue13450] add assertions to implement the intent in ''.format_map test

2011-11-21 Thread akira
Changes by akira <4kir4...@gmail.com>: -- title: fix ''.format_map test -> add assertions to implement the intent in ''.format_map test ___ Python tracker ___ __