[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

Changes by Oleg Plakhotnyuk : Added file: http://bugs.python.org/file23934/test_aifc.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23931/test_aifc.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

Oleg Plakhotnyuk added the comment: Second patch goes to issue 13589 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

Oleg Plakhotnyuk added the comment: Sounds perfectly reasonable. Here goes the first patch with pure test coverage. -- Added file: http://bugs.python.org/file23931/test_aifc.patch ___ Python tracker __

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23734/test_aifc.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

Ezio Melotti added the comment: I think the patch includes too many changes. It would be better if you can split it in two separate patches: one with the increased coverage, the other with the bugs you found and their tests. I can easily commit the first (assuming it doesn't break the test su

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23733/test_aifc.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

Oleg Plakhotnyuk added the comment: Minor style fixes -- Added file: http://bugs.python.org/file23734/test_aifc.patch ___ Python tracker ___

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23677/test_aifc.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

Oleg Plakhotnyuk added the comment: 1. Test coverage increased to 95%. 2. G722 compressed files reading in aifc.py fixed (it used to use 0 bytes frame size). 3. audioop's ulaw2lin, alaw2lin and adpcm2lin length checks fixed (width should be used for output only, because input sequence frame le

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23678/test_aifc2.patch ___ Python tracker ___ ___ Python-bugs-list mail

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

Oleg Plakhotnyuk added the comment: Thanks for your review, Ezio! Here goes new patch with all issues you've mentioned been fixed. -- Added file: http://bugs.python.org/file23678/test_aifc2.patch ___ Python tracker

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

Changes by Ezio Melotti : -- nosy: +r.david.murray stage: -> patch review versions: +Python 3.2, Python 3.3 -Python 3.4 ___ Python tracker ___ __

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

New submission from Oleg Plakhotnyuk : I've increased coverage of aifc.py by test_aifc.py: before: [1/1] test_aifc lines cov% module (path) 56063% aifc (/Users/family/Documents/code/python/repo/Lib/aifc.py) ... after: [1/1] test_aifc lines cov% module (path) 56182%