[issue13388] document hg commit hooks in the devguide

Eli Bendersky added the comment: Éric, feel free to fix it to your heart's desire ;-) I think that having it documented is far more important than nuances in nomenclature, so I'm -0 on this. -- ___ Python tracker

[issue13388] document hg commit hooks in the devguide

Éric Araujo added the comment: > The commit details (including its changeset, branch and commit message) In Mercurial terminology, a changeset *is* a commit (or if you really want to make a distinction, a commit is the action that creates a changeset). I think you meant “diff”. Moreover, on

[issue13388] document hg commit hooks in the devguide

Changes by Ezio Melotti : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___ Pyt

[issue13388] document hg commit hooks in the devguide

Eli Bendersky added the comment: Committed, with the fix suggested by Éric -- resolution: fixed -> stage: committed/rejected -> status: closed -> open ___ Python tracker ___ _

[issue13388] document hg commit hooks in the devguide

Roundup Robot added the comment: New changeset 21758f27f98f by Eli Bendersky in branch 'default': document existing hooks for commit messages mentioning issues. Closes issue 13388 http://hg.python.org/devguide/rev/21758f27f98f -- resolution: -> fixed stage: -> committed/rejected stat

[issue13388] document hg commit hooks in the devguide

Éric Araujo added the comment: +1 to most of the patch, except one piece of wording: “commit message hooks”. This does not occur in the Mercurial documentation or help, and is misleading (commits happen on your maching, the hooks run on the server). I’d just use “hooks” or “Mercurial hooks”

[issue13388] document hg commit hooks in the devguide

Eli Bendersky added the comment: An updated patch attached, explaining that several issues can be mentioned in a single commit message -- Added file: http://bugs.python.org/file23683/issue13388.2.patch ___ Python tracker

[issue13388] document hg commit hooks in the devguide

Eli Bendersky added the comment: Nice, I didn't know about issue #2771 ;-) Will update the patch! -- ___ Python tracker ___ ___ Pyth

[issue13388] document hg commit hooks in the devguide

Ezio Melotti added the comment: ...because the hook now supports multiple issue id in the same commit message. -- ___ Python tracker ___

[issue13388] document hg commit hooks in the devguide

Roundup Robot added the comment: New changeset e4fcac92a80a by Ezio Melotti in branch 'default': Closes #2771. #13388 now needs to be updated. http://hg.python.org/test/rev/e4fcac92a80a -- nosy: +python-dev ___ Python tracker

[issue13388] document hg commit hooks in the devguide

Petri Lehtinen added the comment: Ah, sorry. I didn't check other files in the devguide. The ReST parser is OK with any underline character, as long as it's consistent within a single file. -- ___ Python tracker

[issue13388] document hg commit hooks in the devguide

Eli Bendersky added the comment: Petri, I have actually tried to stay consistent within the same document, and it uses ' for this level of heading. Perhaps it's just not following the Sphinx guide? IIRC the restructured text parser will also shout at you if these are inconsistent. -

[issue13388] document hg commit hooks in the devguide

Petri Lehtinen added the comment: I'm not sure if it matters, but Sphinx documentation suggests using ^ as the underlining character for subsubsections. Otherwise, looks good. -- nosy: +petri.lehtinen ___ Python tracker

[issue13388] document hg commit hooks in the devguide

Eli Bendersky added the comment: Attaching a patch with the suggested change. Based on the doc-string in the implementation of the hook. -- keywords: +patch Added file: http://bugs.python.org/file23669/issue13388.1.patch ___ Python tracker

[issue13388] document hg commit hooks in the devguide

New submission from Eli Bendersky : Our Hg repo has some useful hooks on commit messages that allow to specify which issue to notify for commits, and which issue to close. AFAIU, it's currently documented only in the code of the hook (http://hg.python.org/hooks/file/tip/hgroundup.py). I thi