[issue13361] getLogger does not check its argument

Eric Snow added the comment: FYI, the following changesets were also for this issue. They had the wrong issue number (#13661, which doesn't actually exist so no big deal), which is why they didn't show up in this issue automatically. New changeset 5f3b7528b144 by Vinay Sajip in branch '2.7'

[issue13361] getLogger does not check its argument

Roundup Robot added the comment: New changeset 60dd1568bbd1 by Vinay Sajip in branch '2.7': Closes #13361: Raise correct exception type. http://hg.python.org/cpython/rev/60dd1568bbd1 New changeset bc05c11b340e by Vinay Sajip in branch '3.2': Closes #13361: Raise correct exception type. http://h

[issue13361] getLogger does not check its argument

Vinay Sajip added the comment: @Florent: Sorry, I didn't see your patch, for some reason. But I would say: 1. I agree that where I put the check (logging.getLogger) does not catch the case where someone instantiates the logger directly (using logging.Logger(any)), but users aren't supposed to

[issue13361] getLogger does not check its argument

Florent Xicluna added the comment: btw, changeset a3ba905447ba does not fix the case for: import logging log = logging.Logger(any) -- ___ Python tracker ___ ___

[issue13361] getLogger does not check its argument

Florent Xicluna added the comment: I've uploaded two proposals: - first with isinstance(name, str) - second which is more duck-friendly Personally, I like ducks. -- stage: needs patch -> patch review Added file: http://bugs.python.org/file23623/issue13361_dont_check.diff ___

[issue13361] getLogger does not check its argument

Roundup Robot added the comment: New changeset 8c719e106694 by Vinay Sajip in branch 'default': Merged fix for #13361 from 3.2. http://hg.python.org/cpython/rev/8c719e106694 -- nosy: +python-dev ___ Python tracker

[issue13361] getLogger does not check its argument

Changes by Florent Xicluna : -- keywords: +patch Added file: http://bugs.python.org/file23622/issue13361_check.diff ___ Python tracker ___ ___

[issue13361] getLogger does not check its argument

Changes by Florent Xicluna : -- nosy: +vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue13361] getLogger does not check its argument

New submission from Florent Xicluna : >>> import logging >>> log = logging.getLogger(any) Traceback (most recent call last): File "", line 1, in File "./Lib/logging/__init__.py", line 1730, in getLogger return Logger.manager.getLogger(name) File "./Lib/logging/__init__.py", line 1114,