[issue13287] urllib.request exposes too many names

2011-11-04 Thread Florent Xicluna
Changes by Florent Xicluna : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue13287] urllib.request exposes too many names

2011-11-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset ca78ed7393bf by Florent Xicluna in branch 'default': Fix test_urllib2 error on Windows in relation with issue #13287. http://hg.python.org/cpython/rev/ca78ed7393bf -- ___ Python tracker

[issue13287] urllib.request exposes too many names

2011-11-04 Thread STINNER Victor
STINNER Victor added the comment: test_urllib2.test___all__() is failing on Windows. Example: http://www.python.org/dev/buildbot/all/builders/x86%20XP-4%203.x/builds/5498/steps/test/logs/stdio == FAIL: test___all__ (test.test_

[issue13287] urllib.request exposes too many names

2011-11-01 Thread Senthil Kumaran
Senthil Kumaran added the comment: Thanks flox for the patch. Just the News item is added. I don't think, this requires any Docs update. One change I had to make in the patch is to remote HTTPSHandler from __all__ because that is only conditionally available when http.client supports HTTPSCo

[issue13287] urllib.request exposes too many names

2011-11-01 Thread Roundup Robot
Roundup Robot added the comment: New changeset 70dedd8ce8f3 by Senthil Kumaran in branch 'default': issue13287 - Define __all__ for urllib.request and urllib.error and expose only http://hg.python.org/cpython/rev/70dedd8ce8f3 -- nosy: +python-dev ___

[issue13287] urllib.request exposes too many names

2011-10-28 Thread Florent Xicluna
Florent Xicluna added the comment: We should only expose the names which are documented. The modules and the objects from urllib.parse don't need to be exposed in urllib.request. I suggest to apply this patch on 3.3 only. -- keywords: +patch stage: needs patch -> patch review Added fi

[issue13287] urllib.request exposes too many names

2011-10-28 Thread Senthil Kumaran
Senthil Kumaran added the comment: Let's deprecate some of these (or add deprecation warnings) for upcoming release. But, doing from xxx import * is not a recommended way for any module, as we know that it stands to pollute the namespace with unneccesary functions/methods. I would be careful in

[issue13287] urllib.request exposes too many names

2011-10-28 Thread Ezio Melotti
Ezio Melotti added the comment: This is technically backward incompatible, so if we define an __all__ with most of these names, we are officially making them public, if we leave them out, from urllib.request import * will break for someone. You could argue that import * is discouraged though.

[issue13287] urllib.request exposes too many names

2011-10-28 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +orsenthil ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue13287] urllib.request exposes too many names

2011-10-28 Thread Florent Xicluna
New submission from Florent Xicluna : >>> len(dir()) 4 >>> import urllib.request import * >>> len(dir()) 88 In this list we find 14 modules: ['base64', 'collections', 'ssl', 'bisect', 'http', 're', 'email', 'socket', 'os', 'posixpath', 'hashlib', 'io', 'time', 'sys'] And many non-documented f