[issue13175] packaging uses wrong line endings in RECORD files on Windows

Éric Araujo added the comment: This issue is now obsolete for distutils2. Other projects that write RECORD files are hopefully more robust in their code and tests. -- resolution: -> out of date stage: -> committed/rejected status: open -> closed _

[issue13175] packaging uses wrong line endings in RECORD files on Windows

Éric Araujo added the comment: I should be able to run a VM to test and commit this soon. Keep faith! -- ___ Python tracker ___ ___

[issue13175] packaging uses wrong line endings in RECORD files on Windows

Paul Moore added the comment: >> Do I need to hg clone then do some magic pip incantation to get it installed? > Why would you want to install it?  Clone it, hack on it in place, run tests > in place.  :) > > FTR, “bin/pip install -e .” is the command to “install” a project in develop > (or ed

[issue13175] packaging uses wrong line endings in RECORD files on Windows

Éric Araujo added the comment: > I just did pip install distutils2 in a virtualenv. If that doesn't work then > yes, > I got the wrong one :-( You need to get a development repo to make patches, not a released version, just like for CPython. > Do I need to hg clone then do some magic pip inca

[issue13175] packaging uses wrong line endings in RECORD files on Windows

Paul Moore added the comment: > Maybe you’re using the old PyPI release or Tarek’s outdated Bitbucket > repository.  http://hg.python.org/distutils is current, contains pysetup and > supports -m distutils2.run. I just did pip install distutils2 in a virtualenv. If that doesn't work then yes,

[issue13175] packaging uses wrong line endings in RECORD files on Windows

Éric Araujo added the comment: > I tried to reproduce using distutils2, but don't know how distutils2 > works - there's no pysetup and python -m distutils2.run doesn't work > the same as python -m packaging.run. Maybe you’re using the old PyPI release or Tarek’s outdated Bitbucket repository.

[issue13175] packaging uses wrong line endings in RECORD files on Windows

Paul Moore added the comment: Any progress on this one? I tried to reproduce using distutils2, but don't know how distutils2 works - there's no pysetup and python -m distutils2.run doesn't work the same as python -m packaging.run. Can we at least get packaging working in time for 3.3, even i

[issue13175] packaging uses wrong line endings in RECORD files on Windows

Éric Araujo added the comment: >>> The file passed to csv.writer should be opened with newline=''. >> How will we port this to 2.x? > No idea :-( The 2.7 documentation says use the 'b' flag, but that > probably doesn't allow an encoding parameter (it doesn't on 3.x). Ah, I see that newline cont

[issue13175] packaging uses wrong line endings in RECORD files on Windows

Paul Moore added the comment: On 17 October 2011 14:15, Éric Araujo wrote: >> The file passed to csv.writer should be opened with newline=''. > How will we port this to 2.x? No idea :-( The 2.7 documentation says use the 'b' flag, but that probably doesn't allow an encoding parameter (it doesn

[issue13175] packaging uses wrong line endings in RECORD files on Windows

Éric Araujo added the comment: > I found the problem - it's in packaging.util.write_record_file. We have two functions that write RECORD files; I’ve opened a report to kill one. > The file passed to csv.writer should be opened with newline=''. How will we port this to 2.x? > I don't expect the

[issue13175] packaging uses wrong line endings in RECORD files on Windows

Paul Moore added the comment: Here's a patch. It includes a test, but I don't expect the test will catch the issue except on Windows... -- keywords: +patch Added file: http://bugs.python.org/file23416/recordfix.patch ___ Python tracker

[issue13175] packaging uses wrong line endings in RECORD files on Windows

Paul Moore added the comment: I found the problem - it's in packaging.util.write_record_file. The file passed to csv.writer should be opened with newline=''. -- ___ Python tracker _

[issue13175] packaging uses wrong line endings in RECORD files on Windows

Paul Moore added the comment: Windows 7, 32 bit. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue13175] packaging uses wrong line endings in RECORD files on Windows

Vinay Sajip added the comment: I'm trying to reproduce this too, but have failed so far. Which version(s) of Windows did the problems appear on? -- nosy: +vinay.sajip ___ Python tracker __

[issue13175] packaging uses wrong line endings in RECORD files on Windows

Paul Moore added the comment: Unfortunately, no. I have been unable to get this in a reproducible form - but I have seen it a few times now. I will keep trying to reproduce. The worst thing is that packaging fails to recognise the data in RECORD and won't uninstall the package. It would be he

[issue13175] packaging uses wrong line endings in RECORD files on Windows

Éric Araujo added the comment: packaging.util creates a RECORD file with OS-specific line endings and csv.writerow; packaging.command.install_distinfo uses LF everywhere and csv.writerow. I’m not sure this is related to binary vs. text I/O; maybe it’s some other code like the RESOURCES syste

[issue13175] packaging uses wrong line endings in RECORD files on Windows

New submission from Paul Moore : On Windows, packaging seems to create RECORD files with an additional CR at the end of the line. (So the line end is CR CR LF). This does not seem to be consistent, but it is likely to be because a file is being opened in text mode rather than binary. I am try