[issue13054] sys.maxunicode value after PEP-393

Ezio Melotti added the comment: The buildbot seems happy, so I'm closing this. Antoine already took care of test_bigmem, and Victor opened #13100 for sre_compile. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed

[issue13054] sys.maxunicode value after PEP-393

Roundup Robot added the comment: New changeset f39b26ca7f3d by Ezio Melotti in branch 'default': #13054: fix usage of sys.maxunicode after PEP-393. http://hg.python.org/cpython/rev/f39b26ca7f3d -- ___ Python tracker

[issue13054] sys.maxunicode value after PEP-393

Antoine Pitrou added the comment: I think there's no point in deprecating a function (or data) with a perfectly valid definition. As for test_bigmem, better keep character_size hardwired to 1 (if all tests really use only ASCII chars, which I'm not sure they do). -- _

[issue13054] sys.maxunicode value after PEP-393

STINNER Victor added the comment: As said on IRC, unicodesize and character_size should be 1 before the test is something like 'x'*1. Or you can just remove this constant, it's not very useful to have a constant equal to 1 :-) -- ___ Python tracker

[issue13054] sys.maxunicode value after PEP-393

Ezio Melotti added the comment: I added PyUnicode_GetMax to the list of deprecated functions in PEP 393 in http://hg.python.org/peps/rev/9a154edf18e6. (I'm also adding Antoine to the nosy because he might know something about test_bigmem.) -- nosy: +pitrou stage: test needed -> patch

[issue13054] sys.maxunicode value after PEP-393

Ezio Melotti added the comment: Attached a second patch that fixes checks like: if sys.maxunicode == 65535: ... There are a couple of places (e.g. test_bigmem) where I'm not sure what the best fix is, so I added a couple of XXX in the patch. If you have any suggestion please comment eith

[issue13054] sys.maxunicode value after PEP-393

Roundup Robot added the comment: New changeset 606652491366 by Ezio Melotti in branch 'default': #13054: sys.maxunicode is now always 0x10. http://hg.python.org/cpython/rev/606652491366 -- nosy: +python-dev ___ Python tracker

[issue13054] sys.maxunicode value after PEP-393

Martin v. Löwis added the comment: Sounds all fine to me. As the PEP specifies, all deprecation will only be on paper for now, not in the code. Adding PyUnicode_GetMax to the list sounds fine to me as well. -- ___ Python tracker

[issue13054] sys.maxunicode value after PEP-393

Ezio Melotti added the comment: Attached initial patch that sets the value of sys.maxunicode to 0x10, adds a test, and document the change in both the sys.rst doc and in the 3.3 whatsnew. The patch doesn't include any deprecation. If we decide to deprecate something the PEP and possibly

[issue13054] sys.maxunicode value after PEP-393

New submission from Ezio Melotti : Now that PEP 393 is in and the distinction between narrow and wide doesn't exist anymore, the value of sys.maxunicode should always be 0x10. sys.maxunicode currently uses PyUnicode_GetMax (Objects/unicodeobject.c:196) and still returns either 0x10 if