[issue13026] Dis module - documentation of MAKE_FUNCTION

2013-10-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset b9ab48c491d5 by Georg Brandl in branch '3.3': Closes #13026: fix documentation of MAKE_FUNCTION for 3.x. http://hg.python.org/cpython/rev/b9ab48c491d5 -- nosy: +python-dev resolution: -> fixed stage: needs patch -> committed/rejected status

[issue13026] Dis module - documentation of MAKE_FUNCTION

2012-01-08 Thread Terry J. Reedy
Terry J. Reedy added the comment: "For each keyword only default" is not in my text, but if you are referring to "keyword only name, default parameter object pairs ", yes. Here is a revised suggested wording: MAKE_FUNCTION(argc) Pushes a new function object on the stack. From bottom to top, t

[issue13026] Dis module - documentation of MAKE_FUNCTION

2012-01-08 Thread Sandro Tosi
Sandro Tosi added the comment: Hi Arnaud, would you like to provide a patch to update the MAKE_FUNCTION opcode description? That would speed up a bit the fix-up. Also, I don't have that clear what "For each keyword only default, ..." mean: are those the default values for keyword arguments? s

[issue13026] Dis module - documentation of MAKE_FUNCTION

2011-09-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Agreed -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue13026] Dis module - documentation of MAKE_FUNCTION

2011-09-22 Thread Arnaud Delobelle
Arnaud Delobelle added the comment: This reads a lot better. Perhaps change (with name and object in separate positions) to something like (with name just below object on the stack) -- ___ Python tracker

[issue13026] Dis module - documentation of MAKE_FUNCTION

2011-09-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Right. This opcode is the end of a sequence of opcodes that sets up the stack in the way expected. Perhaps something like Pushes a new function object on the stack. From bottom to top, the consumed stack must have have argc & 0xFF positional default parameter

[issue13026] Dis module - documentation of MAKE_FUNCTION

2011-09-21 Thread Arnaud Delobelle
Arnaud Delobelle added the comment: Yes, you are correct. Reading this again, I don't think I should have used the word "pushed" as it sounds like the effect of the opcode is to push stuff onto the stack, whereas I was only trying to describe what is on the stack just before the opcode is ex

[issue13026] Dis module - documentation of MAKE_FUNCTION

2011-09-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: Minor edit: in 'which are push below TOS', /push/pushed/. I understand 'in this order' to mean that positional defaults are pushed first so that they end up on the bottom, whereas annotations are pushed last and end up just under the code object. Correct? (Thi

[issue13026] Dis module - documentation of MAKE_FUNCTION

2011-09-21 Thread Arnaud Delobelle
New submission from Arnaud Delobelle : The description of the opcode MAKE_FUNCTION in the dis module document is out of date. It still describes the 2.X version of the opcode: """ MAKE_FUNCTION(argc) Pushes a new function object on the stack. TOS is the code associated with the function. The