[issue12943] tokenize: add python -m tokenize support back

Changes by Meador Inge : -- assignee: docs@python -> meador.inge resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue12943] tokenize: add python -m tokenize support back

Roundup Robot added the comment: New changeset 85254bb6c1c6 by Meador Inge in branch 'default': Issue #12943: python -m tokenize support has been added to tokenize. http://hg.python.org/cpython/rev/85254bb6c1c6 -- nosy: +python-dev ___ Python tracker

[issue12943] tokenize: add python -m tokenize support back

Meador Inge added the comment: Éric, thanks. I fixed most of your points. And thanks to everyone that reviewed this. Much appreciated. -- ___ Python tracker ___

[issue12943] tokenize: add python -m tokenize support back

Éric Araujo added the comment: I made a few last remarks on Rietveld; feel free to address or ignore them and commit right away. -- nosy: +eric.araujo ___ Python tracker ___ __

[issue12943] tokenize: add python -m tokenize support back

Meador Inge added the comment: Fixed a few more nits pointed out in review. -- Added file: http://bugs.python.org/file23304/issue12943-6.patch ___ Python tracker ___ ___

[issue12943] tokenize: add python -m tokenize support back

Georg Brandl added the comment: I would say this looks good now. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue12943] tokenize: add python -m tokenize support back

Meador Inge added the comment: > I don't think the help option needs to be documented, it will document > itself. Normally I would document it anyway, but in this case there is only the one option. So, I dropped it. > An additional suggestion is to catch errors on tokenizing and exiting > w

[issue12943] tokenize: add python -m tokenize support back

Georg Brandl added the comment: I don't think the help option needs to be documented, it will document itself. An additional suggestion is to catch errors on tokenizing and exiting with a non-zero exit status in these cases. -- ___ Python tracker

[issue12943] tokenize: add python -m tokenize support back

Meador Inge added the comment: Updated patch which adds and documents a '-h,--help' option. This option was suggested during code review. -- Added file: http://bugs.python.org/file23196/issue12943-4.patch ___ Python tracker

[issue12943] tokenize: add python -m tokenize support back

Meador Inge added the comment: Updated patch fixing some issues pointed out by Ezio on Rietveld. -- Added file: http://bugs.python.org/file23193/issue12943-3.patch ___ Python tracker __

[issue12943] tokenize: add python -m tokenize support back

Meador Inge added the comment: > Did you get commit rights already? I have not. I still need to submit a contributor agreement as well. I plan to fax that today. -- ___ Python tracker __

[issue12943] tokenize: add python -m tokenize support back

Georg Brandl added the comment: Looks good to me. Did you get commit rights already? -- nosy: +georg.brandl ___ Python tracker ___ __

[issue12943] tokenize: add python -m tokenize support back

Meador Inge added the comment: v2 patch which addresses comments made by merwok via rietveld. -- Added file: http://bugs.python.org/file23184/issue12943-2.patch ___ Python tracker _

[issue12943] tokenize: add python -m tokenize support back

Meador Inge added the comment: Patch against tip. -- assignee: -> docs@python components: +Documentation keywords: +needs review, patch nosy: +docs@python stage: needs patch -> patch review Added file: http://bugs.python.org/file23127/issue12943.patch _

[issue12943] tokenize: add python -m tokenize support back

New submission from Meador Inge : In 2.x, 'python -m tokenize' worked great: [meadori@motherbrain cpython]$ python2.7 -m tokenize test.py 1,0-1,5:NAME'print' 1,6-1,21: STRING '"Hello, World!"' 1,21-1,22: NEWLINE '\n' 2,0-2,0:ENDMARKER '' In 3.x, however, th