[issue12923] test_urllib fails in refleak mode

2016-02-04 Thread Martin Panter
Martin Panter added the comment: One extra change I made to test_redirect_limit_independent() was to stop relying on _urlopener being created before we call urlopen(). As a consequence, in the Python 3 tests I made a wrapper around FancyURLopener to suppress the deprecation warning. -

[issue12923] test_urllib fails in refleak mode

2016-02-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset eb69070e5382 by Martin Panter in branch '3.5': Issue #12923: Reset FancyURLopener's redirect counter even on exception https://hg.python.org/cpython/rev/eb69070e5382 New changeset a8aa7944c5a8 by Martin Panter in branch '2.7': Issue #12923: Reset Fa

[issue12923] test_urllib fails in refleak mode

2015-12-13 Thread Martin Panter
Martin Panter added the comment: I guess this is a real bug so should also be applied to Python 2. This patch combines the previous three, and tweaks a couple things: * Rename the test function * Drop irrelevant header lines -- components: +Library (Lib) versions: +Python 2.7, Python 3

[issue12923] test_urllib fails in refleak mode

2015-12-05 Thread Martin Panter
Martin Panter added the comment: All three patches look generally good to me. I left some comments on things I would change. FTR the tests fail to raise any exception when the redirect limit is reached because FancyURLopener.http_error_default() does not raise an error. It just returns the la

[issue12923] test_urllib fails in refleak mode

2015-12-03 Thread R. David Murray
Changes by R. David Murray : -- nosy: +martin.panter ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue12923] test_urllib fails in refleak mode

2015-04-14 Thread Daniel Rocco
Daniel Rocco added the comment: Hi, Here is an alternate patch to the test suite that demonstrates the failure without needing refleak mode. The test works by issuing enough requests that, if retries are not independent per request, the test triggers the code path that results in the test faili

[issue12923] test_urllib fails in refleak mode

2014-05-13 Thread Stefan Krah
Changes by Stefan Krah : -- nosy: -skrah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.o

[issue12923] test_urllib fails in refleak mode

2011-12-14 Thread Meador Inge
Meador Inge added the comment: I just noticed this problem as well. I don't know the code well enough to determine if Brian's patch is the right thing to do. The documentation claims that maxtries is used to put a limit on recursion: http://docs.python.org/dev/library/urllib.request.html#urll

[issue12923] test_urllib fails in refleak mode

2011-10-09 Thread Brian Brazil
Brian Brazil added the comment: Here's a path to fix the problem. -- Added file: http://bugs.python.org/file23359/12923-maxtries-reset.patch ___ Python tracker ___ _

[issue12923] test_urllib fails in refleak mode

2011-10-09 Thread Brian Brazil
Brian Brazil added the comment: The actual problem is that FancyURLOpener self.tries isn't being reset if the protocol is file:// I've attached a patch that'll help improve the test at least. -- keywords: +patch Added file: http://bugs.python.org/file23358/12923-unittest-improvement.p

[issue12923] test_urllib fails in refleak mode

2011-10-09 Thread Brian Brazil
Brian Brazil added the comment: This appears to fail every 9th, 19th, 29th, etc. repetition of the test. This seems to be something to do with the reference counting/close logic of the FakeSocket but I haven't managed to figure out what. -- nosy: +bbrazil ___

[issue12923] test_urllib fails in refleak mode

2011-09-06 Thread Stefan Krah
New submission from Stefan Krah : Hi, test_urllib fails in refleak mode: ./python -m test -uall -v -R : test_urllib == FAIL: test_invalid_redirect (test.test_urllib.urlopen_HttpTests) -